๐จ Palette: [UX improvement] ์ธ๋ถ ๋งํฌ์ ์ ์ฐฝ ์ด๋ฆผ ํดํ(title) ์ถ๊ฐ #193
+36
โ22
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -144,7 +144,8 @@ const messages = { | |
| "work.fourTitle": "์์ ํ๋ฆ", | ||
| "work.fourBody": "๋ฐ๋ณต ํ์์ ์ค์ด๊ณ ๊ทผ๊ฑฐ ํ์ธ๊ณผ ์ฌ๋์ ํ๋จ์ ๋จ๊ธฐ๋ ํ๋ฆ.", | ||
| "footer.founded": "Founded by", | ||
| "footer.line": "Context into judgment. Judgment into action.", | ||
| "a11y.newWindow": "(์ ์ฐฝ์์ ์ด๋ฆผ)" | ||
| }, | ||
| en: { | ||
| metaTitle: "Contextual Wisdom Lab", | ||
|
|
@@ -291,7 +292,8 @@ const messages = { | |
| "work.fourTitle": "Agentic workflows", | ||
| "work.fourBody": "Workflows that reduce repeated search while preserving evidence checks and human judgment.", | ||
| "footer.founded": "Founded by", | ||
| "footer.line": "Context into judgment. Judgment into action.", | ||
| "a11y.newWindow": "(Opens in a new tab)" | ||
| } | ||
| }; | ||
|
|
||
|
|
@@ -365,14 +367,22 @@ function setLanguage(lang) { | |
|
|
||
| if (!isInitialDefault) { | ||
| if (!i18nNodes) { | ||
| i18nNodes = document.querySelectorAll("[data-i18n], [data-i18n-title]"); | ||
| } | ||
|
|
||
| // Only update textContent if it actually changed to avoid layout recalculations | ||
| i18nNodes.forEach((node) => { | ||
| if (node.hasAttribute("data-i18n")) { | ||
| const newText = dict[node.dataset.i18n]; | ||
| if (newText && node.textContent !== newText) { | ||
| node.textContent = newText; | ||
| } | ||
| } | ||
| if (node.hasAttribute("data-i18n-title")) { | ||
| const newTitle = dict[node.dataset.i18nTitle]; | ||
| if (newTitle && node.getAttribute("title") !== newTitle) { | ||
| node.setAttribute("title", newTitle); | ||
| } | ||
| } | ||
| }); | ||
| } | ||
|
Comment on lines
367
to
388
There was a problem hiding this comment. ๐ Info: Initial Korean load skips title translation, stays consistent On initial Korean load (Refers to this code) 
Was this helpful? React with ๐ or ๐ to provide feedback. |
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ Info: Palette entry date likely off by two years
The new entry is dated
2024-08-25while the change lands in 2026. Given the journal records recent incidents, this reads as a typo, though other entries also use 2024 dates so intent is ambiguous.Was this helpful? React with ๐ or ๐ to provide feedback.