docs(gap-baseline): document the opencode-review required-check race - #1485
docs(gap-baseline): document the opencode-review required-check race#1485seonghobae wants to merge 1 commit into
Conversation
The opencode-review required check (job opencode-review-target in opencode-review.yml) checks synchronously, within seconds of push, whether an opencode-agent review already exists for the current head -- but the real review is posted by a separate, asynchronous path (pr-review-merge-scheduler.yml's TRIGGER_REVIEWS -> repository_dispatch: opencode-review -> opencode-review-dispatch.yml) that can take far longer. Nothing re-runs the check once the real review lands, since opencode-review.yml's only trigger is pull_request_target, unlike noema-review.yml and pr-review-merge-scheduler.yml which both also listen for workflow_run completion. Confirmed live on 5 independent PRs across .github and contextual-orchestrator (contextual-orchestrator#953, .github#1437/#1478/#1479/#1482), all failing identically within 1-10 seconds of push, and confirmed not a flake (an immediate re-run reproduces the same race). Documented rather than fixed this pass: this is required-workflow, pull_request_target trust-boundary code shared by every sibling repo, and multiple sessions were independently pushing to the same review-pipeline files while this was diagnosed. Landing a fix needs deliberate, single-owned attention in its own PR, not a rushed addition to an unrelated one. Two candidate directions are recorded for whoever picks this up. Docs-only change; full suite 2105 passed, 1 skipped, 21 subtests; 100% coverage; 100% docstrings; test_product_technical_gap_baseline.py contract tests pass unchanged.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The Generated by Claude Code |
|
Closing: The five PRs this entry cites as evidence ( Generated by Claude Code |
Summary
Documents a structural, org-wide gap found while driving several other PRs to green this session: the
opencode-reviewrequired check (jobopencode-review-targetinopencode-review.yml) checks synchronously, within seconds of push, whether anopencode-agentreview already exists for the current head — but the real review is posted by a separate, asynchronous path (pr-review-merge-scheduler.yml'sTRIGGER_REVIEWS→repository_dispatch: opencode-review→opencode-review-dispatch.yml) that can take far longer. Nothing re-runs the check once the real review lands, sinceopencode-review.yml's only trigger ispull_request_target, unlikenoema-review.ymlandpr-review-merge-scheduler.yml, which both also listen forworkflow_runcompletion.Confirmed live on 5 independent PRs across
.githubandcontextual-orchestrator(contextual-orchestrator#953,.github#1437/#1478/#1479/#1482), all failing identically within 1–10 seconds of push, and confirmed not a flake — an immediate re-run reproduces the same race.Documented rather than fixed this pass: this is required-workflow,
pull_request_targettrust-boundary code shared by every sibling repo, and multiple sessions were independently pushing to the same review-pipeline files while this was being diagnosed. Landing a fix needs deliberate, single-owned attention in its own PR — two candidate directions are recorded in the entry for whoever picks this up.Test plan
PYTHONPATH=. coverage run -m pytest tests -q— 2105 passed, 1 skipped, 21 subtestscoverage report --show-missing— 100%interrogate— 100%tests/test_product_technical_gap_baseline.py— passes unchangedGenerated by Claude Code