chore(ci): remove orphaned direct-NVIDIA-NIM model resolver - #1445
chore(ci): remove orphaned direct-NVIDIA-NIM model resolver#1445seonghobae wants to merge 1 commit into
Conversation
Audited this repository for CI consumers that talk to a provider directly instead of through the vendored contextual-orchestrator gateway (ADR-0003). scripts/ci/select_nvidia_nim_model.py opened a direct HTTPSConnection to integrate.api.nvidia.com with a raw provider API key to resolve a live NVIDIA NIM model id for the scheduled autofix worker -- a real direct-provider bypass, exactly the pattern ADR-0003 migrated pr-review-autofix.yml away from. Confirmed by repository-wide search that it was wired into nothing: pr-review-autofix.yml (its only plausible caller) has no reference to it, and no live NVIDIA/mistral model id, base URL, or provider name -- test_scheduled_autofix_routes_through_contextual_orchestrator already pins "https://integrate.api.nvidia.com/v1" as a forbidden string in that workflow. The only reference anywhere in the repository was the script's own dedicated test. Orphaned dead code predating the ADR-0003 gateway migration; removed along with tests/test_select_nvidia_nim_model.py. Not the same thing as contextual-orchestrator's own legitimate internal support for NVIDIA NIM as one of its five backend providers, which is unmodified and out of this repository's scope. Also corrects four stale pre-ADR-0003 documentation references that still described the scheduled autofix worker's model credential as a single hardcoded NVIDIA_NIM_API_KEY used directly, rather than the current five-secret contextual-orchestrator gateway routing: docs/doctoring/hourly-nvidia-nim-autofix.md (dated addendum, extensive historical detail kept as history), docs/doctoring/originweave-hourly-review-caller.md, docs/doctoring/nonnest2-hourly-review-caller.md (one stale sentence each), and docs/automation/hourly-review-repair.md (summary bullet and the Clearfolio credential paragraph, to match language its own already-accurate Orgmetra section used). Split out of #1437 per its exact-head governance review's fifth acceptance criterion: this cleanup is orthogonal to that PR's Strix pool-gating behavior repair (a per-family cap does not create a second outage-domain family) and belongs in its own, independently reviewable and mergeable change, not bundled into a broader policy transition. Test/coverage results: - coverage run -m pytest tests -q: 1864 passed, 1 skipped, 21 subtests - coverage report: 99% total, single pre-existing miss in scripts/ci/pingora_edge_policy.py:274 (untouched by this PR, tracked separately as #1398) - interrogate: 100.0% Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BV96rXhqoR3tYZ9AeAVur4
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing as duplicate of #1442 — same change (remove the orphaned Per this PR's own body: "Whichever of this PR or #1433 merges first will make the other's deletion of these two files a no-op" — same logic applies here between this PR and #1442. Consolidating onto #1442 rather than running two competing PRs through review for the identical deletion. Generated by Claude Code Generated by Claude Code |
What changed
Split out of #1437 per its exact-head governance review's fifth acceptance criterion ("the unrelated direct-NIM dead-code/docs cleanup is split or adopted by its actual owner instead of being bundled into this policy transition"). This PR is narrowly scoped to that cleanup only — it contains no Strix pool-routing behavior change.
scripts/ci/select_nvidia_nim_model.py(+ its dedicated testtests/test_select_nvidia_nim_model.py): a standalone helper that opened a directHTTPSConnectiontointegrate.api.nvidia.comwith a raw provider API key to resolve a live NVIDIA NIM model id — a real direct-provider bypass, exactly the pattern ADR-0003 migratedpr-review-autofix.ymlaway from. Confirmed by repository-wide search that it was wired into nothing:pr-review-autofix.yml(its only plausible caller) has no reference to it, and no live NVIDIA/mistral model id, base URL, or provider name —test_scheduled_autofix_routes_through_contextual_orchestratoralready pinshttps://integrate.api.nvidia.com/v1as a forbidden string in that workflow. The only reference anywhere in the repository was the script's own dedicated test. Orphaned dead code predating the ADR-0003 gateway migration. Not the same thing ascontextual-orchestrator's own legitimate internal support for NVIDIA NIM as one of its five backend providers, which is unmodified and out of this repository's scope.NVIDIA_NIM_API_KEYused directly, rather than the current five-secretcontextual-orchestratorgateway routing:docs/doctoring/hourly-nvidia-nim-autofix.md— dated Update section added; its extensive historical detail kept as history, not rewritten.docs/doctoring/originweave-hourly-review-caller.md,docs/doctoring/nonnest2-hourly-review-caller.md— one stale sentence each, corrected in place.docs/automation/hourly-review-repair.md— summary bullet and the Clearfolio credential paragraph, updated to match the language its own already-accurate Orgmetra section used.Why this is its own PR
The current lane for the Strix
orchestrator/freepool-gating question (#1437, converging on #1433'sfree_family_diversityevidence) is a security/availability-policy decision under active exact-head governance review. This NIM-direct-communication cleanup is orthogonal dead-code removal + doc accuracy — bundling them made #1437's diff harder to audit for exactly the policy question under review. This PR can be reviewed and merged independently of that decision.Note: this same file deletion is also present, independently, in #1433's own commit history (and therefore in #1437's branch, which merged #1433). Whichever of this PR or #1433 merges first will make the other's deletion of these two files a no-op; that's expected and not a conflict to resolve manually.
Test plan
Per this repo's governance model, merge requires OpenCode review approval, applied by the mechanical PR Review Merge Scheduler — this PR is opened as a draft and will not be merged by this session.
🤖 Generated with Claude Code
https://claude.ai/code/session_01BV96rXhqoR3tYZ9AeAVur4
Generated by Claude Code