docs: record full product-goal directive for /goal's 4000-char cap - #1429
Conversation
Add docs/product-goal-directive.md with the complete nine-section autonomous PR review/fix/merge/develop loop directive, verbatim, so a /goal session's length-capped condition field can point to it instead of truncating it. Link the new doc from AGENTS.md, CLAUDE.md, and CWL-MASTER-CONTEXT.md §10 so any agent picks it up during normal read-first onboarding, per this repo's own convention that durable knowledge belongs in the repo, not private agent memory.
|
Warning Review limit reachedNext included review available in 27 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
Changes자율 운영 지침
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🔵 Low · up to The PR adds durable guidance that references multiple provider credentials without explicitly requiring gateway-only routing and privacy-preserving admission for every automated consumer. Existing central workflows limit immediate exposure, so the risk is bounded, but the security wording and one markdown lint issue should be addressed before or with merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The required Root cause found in Fix: marked the PR ready for review, which fires the scheduler's Generated by Claude Code |
|
The required Root cause, per I don't have the five provider secrets locally to reproduce discovery output outside CI, so I can't yet tell whether NVIDIA NIM/OpenAI having zero eligible models right now is itself a bug (e.g. in how Generated by Claude Code |
Devin Review flagged two real issues on the new product-goal-directive.md: this PR's own new standing policy had no docs/doctoring/ record, and section 5's verbatim naming text names wardnet as an "old name" to rename away from and says all snake_case violations should be replaced outright -- both contradicting docs/CWL-MASTER-CONTEXT.md (waf-ids-ai-soc -> wardnet is an already-completed rename; section 7 grandfathers existing Camel/Pascal DB objects). Added a reconciliation note after the quoted section (the quote itself stays verbatim) and docs/doctoring/product-goal-directive.md recording both findings and the fix, per this file's own stated conflict policy.
|
Update on Root cause is already diagnosed and fixed upstream, just not merged yet: #1428 ("bump contextual-orchestrator vendored SHA to PR #919 head") — the pinned This is where it stops being something I can fix from inside #1429: I won't duplicate #1428's fix or attempt to route around its required checks. Watching both PRs; nothing further to push on #1429 for this specific failure until #1428 (or an equivalent base-branch fix) lands, at which point Generated by Claude Code |
CodeRabbit flagged the /goal example's fenced code block for a missing language identifier (MD040) -- changed the opening fence to ```text since it displays a command, not executable code. It also flagged section 8's auto-model-discovery text as readable as CI routing/credential-scope policy; added a note clarifying it describes contextual-orchestrator's general product capability only -- pool selection (OpenCode/Noema -> orchestrator/free, Strix -> orchestrator/auto, ZDR-only for private targets) remains governed exclusively by ADR-0003, per the same conflict-resolution precedent as the section 5 note.
…omlab-product-goals-bfrgv3
|
Update on The sidecar now correctly vendors the fixed pin ( But it still fails closed, one stage later:
This is a distinct, deeper bug than the one #1430 just fixed, in the same shared central sidecar — not something in this PR's own docs-only diff, and not something I can usefully keep chasing layer-by-layer on this PR: there's already a fast-moving, concurrent effort actively iterating on exactly this sidecar right now (#1428/#1430 landed within the last ~40 minutes; the org's own hourly gap-baseline loop tracks this class of issue explicitly). I'll leave this one to that process rather than duplicate it, and keep #1429 watched — its own diff needs no further changes; it's waiting on shared CI infra outside its scope. Generated by Claude Code |
Summary
/goal's session-condition field is capped at 4000 characters; the user's full nine-section autonomous "PR review → fix → re-check GitHub Checks → merge → next development" loop directive is ~7900 characters and would lose specific constraints (exact library list, exact coverage thresholds, exact language mandates) if summarized to fit.docs/product-goal-directive.md, recording the directive verbatim under nine headed sections (execution loop, concurrent-work/root-cause fixes, research/standards traceability, UX/UI, architecture/naming/DB, implementation language/measurement, realistic verification/load/container testing, LLM/orchestration/embedding, reference libraries), plus a short/goal-sized pointer text that a future session can paste in instead of the full text.docs/CWL-MASTER-CONTEXT.md§7: "Durable knowledge lives in the repo / Project / KG, NOT in an agent's private memory") — the directive now lives in the repo with no length limit, and/goalonly needs to hold a pointer to it.AGENTS.md's read-first entry point,CLAUDE.md's "Read first" section, anddocs/CWL-MASTER-CONTEXT.md§10 ("Current state") so any agent picks it up during normal onboarding, regardless of whether it was invoked via/goal, a Routine, or a fresh session.Test plan
PYTHONPATH=. pytest tests -q— 1879 passed, 1 skipped, 1 failed (test_materialized_bounded_include_is_resolvable_by_pip, pre-existing/unrelated: this session's pytest venv has nopipmodule installed, not caused by this doc-only change)tests/test_product_technical_gap_baseline.py(pins narrative pointers indocs/CWL-MASTER-CONTEXT.md§10) passes unchangedAGENTS.mdprose before editing itGenerated by Claude Code
Summary by CodeRabbit