ci(strix): bootstrap live fallback smoke contract - #1355
Conversation
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
# Conflicts: # scripts/ci/strix_required_workflow_smoke.sh
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| assert_file_contains_either \ | ||
| "$workflow_file" \ | ||
| "steps.resolve_nvidia_models.outputs.fallback" \ | ||
| "nvidia_nim/nvidia/llama-3.3-nemotron-super-49b-v1.5" \ | ||
| "Strix accepts the legacy fallback or a live catalog-resolved fallback during migration" | ||
| assert_file_contains_either \ | ||
| "$workflow_file" \ | ||
| "openai_direct/gpt-5.4" \ | ||
| "openai-direct/gpt-5.4" \ | ||
| "Strix retains the cross-provider direct-OpenAI fallback" | ||
| # ponytail: transitional compatibility; require only the dynamic fallback after its workflow lands. | ||
| "steps.gate.outputs.provider_mode == 'nvidia_nim' && 'openrouter/free openai-direct/gpt-5.4'" \ | ||
| "steps.gate.outputs.provider_mode == 'nvidia_nim' && format('{0} openrouter/free openai-direct/gpt-5.4', steps.resolve_nvidia_models.outputs.fallback)" \ | ||
| "Strix accepts the current static fallback or a live catalog fallback crossing OpenRouter before direct OpenAI" |
There was a problem hiding this comment.
📝 Info: Contract relaxation stays fail-closed
The single assert_file_contains_either at strix_required_workflow_smoke.sh folds in the removed bare openrouter/free openai-direct/gpt-5.4 check: both needles embed that literal, and both end in openai-direct/gpt-5.4, so no coverage is lost. The first needle matches strix.yml:875 today; the second anticipates PR #1297's format() resolver form.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Closing: this keeps the trusted Strix smoke on the old NVIDIA → live-catalog → direct OpenAI fallback chain. Org policy is now #1360 (vendored contextual-orchestrator, |
1 participant
Summary
Verification
bash -n scripts/ci/strix_required_workflow_smoke.shgit diff --checkThis bootstrap must merge before #1297 can replace the static model without its trusted base-ref smoke test rejecting the new resolver.