fix(strix): scope direct OpenAI tool fallback effort - #1353
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📝 WalkthroughWalkthrough직접 OpenAI fallback은 네이티브 endpoint에서만 ChangesOpenAI fallback reasoning effort 라우팅
Estimated code review effort: 2 (Simple) | ~15 minutes Merge Risk: 🔵 Low · up to The production fallback behavior is narrowly scoped, but the regression test may inherit an environment variable that makes it validate the wrong API base or fail unexpectedly. The PR is mergeable with explicit owner awareness to unset that variable during the test. Sequence Diagram(s)sequenceDiagram
participant run_strix_once
participant ChildStrixProcess
participant OpenAIEndpoint
run_strix_once->>run_strix_once: API base와 모델 유형 확인
run_strix_once->>ChildStrixProcess: STRIX_REASONING_EFFORT 전달
ChildStrixProcess->>OpenAIEndpoint: function-tools 요청 전송
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 1 unsupported, 1 too large.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Additional exact evidence: contextual-orchestrator PR #869 Strix run |
# Conflicts: # docs/doctoring/strix-openai-fallback-api-base-routing.md # scripts/ci/test_strix_quick_gate.sh
Summary
STRIX_REASONING_EFFORT=noneonly for explicit direct-OpenAI child attempts using function tools over chat completionsRoot cause evidence
Contextual-orchestrator PR #881 run
32967361853exhausted NVIDIA with 429/410 responses, then reachedopenai-direct/gpt-5.4and deterministically failed HTTP 400 because function tools were combined with non-none reasoning effort.Verification
bash scripts/ci/test_strix_quick_gate.sh— PASSbash -n— passactionlint— pass (existing SC2016 informational rule excluded)git diff --check— passThis does not change review-agent credentials, severity thresholds, fail-closed behavior, or protected gates.
Summary by CodeRabbit
개선 사항
버그 수정
테스트