fix(strix): use API-compatible reasoning option for direct OpenAI - #1352
fix(strix): use API-compatible reasoning option for direct OpenAI#1352seonghobae wants to merge 4 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughStrix는 ChangesStrix reasoning effort 조건화
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change adjusts reasoning settings only for direct OpenAI runs while preserving other provider paths, and no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Why
Direct OpenAI Strix runs send function tools through chat-completions. GPT-5.4 rejects a non-neutral reasoning_effort in that mode, so the required security check fails before scanning.
Change
Evidence
pytest -q tests/test_opencode_agent_contract.py -k workflow_provisions_sandbox_tool_and_reviewer_agent(1 passed)git diff --checkpassed.Closes ContextualWisdomLab/disksage#264
Summary by CodeRabbit
none으로 사용하고, 다른 제공자에서는 기존처럼high를 사용하도록 조정했습니다.