Skip to content

fix(strix): use API-compatible reasoning option for direct OpenAI - #1352

Open
seonghobae wants to merge 4 commits into
mainfrom
fix/strix-openai-reasoning-compatibility
Open

fix(strix): use API-compatible reasoning option for direct OpenAI#1352
seonghobae wants to merge 4 commits into
mainfrom
fix/strix-openai-reasoning-compatibility

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Why

Direct OpenAI Strix runs send function tools through chat-completions. GPT-5.4 rejects a non-neutral reasoning_effort in that mode, so the required security check fails before scanning.

Change

  • Set STRIX_REASONING_EFFORT to none only for provider_mode=openai_direct.
  • Preserve high reasoning effort for NVIDIA NIM, OpenRouter, GitHub Models, and Vertex paths.
  • Update the central quick-gate and workflow contract tests.

Evidence

  • pytest -q tests/test_opencode_agent_contract.py -k workflow_provisions_sandbox_tool_and_reviewer_agent (1 passed)
  • git diff --check passed.
  • Root failure observed in fix: verify Windows release artifact namespace disksage#264: OpenAI 400, function tools with reasoning_effort unsupported by /v1/chat/completions.

Closes ContextualWisdomLab/disksage#264


Open in Devin Review

Summary by CodeRabbit

  • 변경 사항
    • 직접 OpenAI 스캔에서는 Strix 추론 수준을 none으로 사용하고, 다른 제공자에서는 기존처럼 high를 사용하도록 조정했습니다.
    • 자식 실행에도 제공자별 추론 수준이 올바르게 전달되도록 개선했습니다.
    • 각 제공자 모드에 맞게 관련 검증과 테스트를 업데이트했습니다.

@seonghobae
seonghobae enabled auto-merge (squash) August 26, 2026 11:41
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fbb3057f-0c80-4448-b4db-30410827b58d

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 68a61167-69a2-4cc1-959c-375f2923cde7

📥 Commits

Reviewing files that changed from the base of the PR and between 8d22308 and 5331cb1.

📒 Files selected for processing (2)
  • scripts/ci/strix_quick_gate.sh
  • tests/test_opencode_agent_contract.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Strix는 openai_direct provider에서 reasoning_effortnone을 사용합니다. 다른 provider에서는 high를 사용합니다. 자식 실행 전달, 워크플로 설정, 빠른 게이트와 계약 테스트를 동일한 조건으로 갱신했습니다.

Changes

Strix reasoning effort 조건화

Layer / File(s) Summary
자식 실행 reasoning effort 전달
scripts/ci/strix_quick_gate.sh, tests/test_opencode_agent_contract.py
run_strix_once는 기본값으로 high를 사용합니다. direct-OpenAI 모델은 none으로 덮어씁니다. 선택한 값은 STRIX_CHILD_REASONING_EFFORT를 통해 자식 프로세스에 전달됩니다. 계약 테스트는 상위 값을 상속하지 않는 동작을 검증합니다.
Provider별 설정 및 검증
.github/workflows/strix.yml, scripts/ci/test_strix_quick_gate.sh, tests/test_opencode_agent_contract.py
openai_direct provider에는 none을 적용합니다. 다른 provider에는 high를 적용합니다. 워크플로와 검증 조건이 이 규칙을 사용합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 5331c

This localized change adjusts reasoning settings only for direct OpenAI runs while preserving other provider paths, and no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: actions

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning PR은 Strix direct OpenAI의 reasoning effort를 변경하지만, 연결된 이슈 #264의 Windows 릴리스 아티팩트 namespace 수정과 Vitest 회귀 테스트를 구현하지 않습니다. 이슈 #264의 요구사항에 맞게 .github/scripts/verify-release-artifacts.sh의 Windows namespace를 windows-2022로 수정하고, 전체 17개 릴리스 아티팩트 세트를 검증하는 Vitest 회귀 테스트를 추가하십시오.
Out of Scope Changes check ⚠️ Warning 모든 변경이 Strix 및 OpenAI reasoning 설정에 해당하며, 연결된 이슈 #264의 릴리스 아티팩트 검증 범위를 벗어납니다. Strix 관련 변경을 별도 이슈 또는 PR로 분리하십시오. 이 PR에는 이슈 #264의 Windows artifact namespace 수정과 관련 회귀 테스트만 포함하십시오.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 direct OpenAI 실행에서 API 호환 reasoning 옵션을 사용하는 핵심 변경을 정확히 요약합니다.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/strix-openai-reasoning-compatibility

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Open in Devin Review

Comment thread scripts/ci/strix_quick_gate.sh Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant