Skip to content

fix(strix): honor GPT-5.4 tool reasoning contract - #1350

Merged
seonghobae merged 2 commits into
mainfrom
fix/strix-gpt54-tool-reasoning-contract
Aug 26, 2026
Merged

fix(strix): honor GPT-5.4 tool reasoning contract#1350
seonghobae merged 2 commits into
mainfrom
fix/strix-gpt54-tool-reasoning-contract

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Root cause

The required Strix workflow correctly exhausted NVIDIA NIM after HTTP 429/410 provider failures, then reached its direct OpenAI fallback. The pinned Strix scanner uses Chat Completions function tools, while direct OpenAI rejected gpt-5.4 when the inherited reasoning_effort=high was present. The fallback therefore produced no authoritative security evidence and remained fail closed.

Repair

  • Preserve high reasoning for every existing supported model path.
  • For the exact direct OpenAI gpt-5.4 fallback only, pass reasoning_effort=none, as required by the provider's observed Chat Completions function-tool contract.
  • Keep vulnerability findings, provider exhaustion, missing artifacts, and all other incomplete scans non-passing.
  • Extend the existing NIM-to-direct-OpenAI fallback regression so it fails if GPT-5.4 inherits an unsupported reasoning effort.

Verification

  • STRIX_TEST_CASE_FILTER=nvidia-rate-limit-openai-direct-fallback-clears-api-base STRIX_TEST_PROCESS_TIMEOUT_SECONDS=3 STRIX_TEST_FAKE_SLEEP_SECONDS=5 bash scripts/ci/test_strix_quick_gate.sh
  • uv run --with pytest pytest -q tests/test_strix_nvidia_nim_not_found_fallback.py tests/test_strix_openai_fallback_api_base.py — 25 passed
  • bash -n scripts/ci/strix_quick_gate.sh scripts/ci/test_strix_quick_gate.sh
  • git diff --check
  • actionlint .github/workflows/strix.yml reports only the existing SC2016 informational diagnostic at unchanged line 267.

Open in Devin Review

@seonghobae
seonghobae enabled auto-merge (squash) August 26, 2026 10:06

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread scripts/ci/strix_quick_gate.sh
@opencode-agent
opencode-agent Bot disabled auto-merge August 26, 2026 12:11
@seonghobae
seonghobae enabled auto-merge (squash) August 26, 2026 12:26
@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent review the current exact head; this change owns the Strix reasoning-effort fallback repair.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 48dee0f6-b4cc-46b8-8e70-3db9e234c38f


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae merged commit f655a90 into main Aug 26, 2026
47 of 48 checks passed
@seonghobae
seonghobae deleted the fix/strix-gpt54-tool-reasoning-contract branch August 26, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant