-
Notifications
You must be signed in to change notification settings - Fork 0
fix(scheduler): resolve live refs before cancelling runs #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seonghobae
wants to merge
2
commits into
main
Choose a base branch
from
fix/queue-hygiene-live-ref-race
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # Queue hygiene live-reference race | ||
|
|
||
| ## Incident | ||
|
|
||
| On 2026-08-26, LineageWeave PR #667 received a new same-repository head | ||
| `37cc9ab1163f213105d420618e2e8ee69ec6673d`. Its new pull-request workflows | ||
| started, but the organization queue sweep cancelled them while GitHub's open-PR | ||
| payload still exposed the preceding head. The runs were current for the branch | ||
| ref and stale only in the pull-request listing used by the cancellation map. | ||
|
|
||
| This was a control-plane defect, not a test failure. Re-running the jobs without | ||
| repairing the comparison source would leave the same race available to every | ||
| repository in the organization. | ||
|
|
||
| ## Decision | ||
|
|
||
| Queue hygiene still enumerates open pull requests to identify eligible head | ||
| repositories and branch names. Before cancelling anything, it now resolves each | ||
| head through GitHub's `Get a reference` endpoint and compares active runs with | ||
| that live Git reference. A missing, inaccessible, or malformed ref makes the | ||
| repository's cancellation pass unavailable; no run is cancelled from partial | ||
| evidence. | ||
|
|
||
| No time delay or grace-period heuristic is used. A branch ref is the exact | ||
| commit pointer the check run is meant to validate. The existing rule remains: | ||
| previous-head runs may be cancelled, current-head runs may not. | ||
|
|
||
| ## Verification | ||
|
|
||
| - `uv run --group dev pytest -q tests/test_required_workflow_queue_contract.py` | ||
| - `actionlint .github/workflows/pr-review-merge-scheduler.yml` | ||
| - `git diff --check` | ||
|
|
||
| ## Reference | ||
|
|
||
| GitHub. (n.d.). *REST API endpoints for Git references*. GitHub Docs. Retrieved | ||
| August 26, 2026, from https://docs.github.com/en/rest/git/refs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.