-
Notifications
You must be signed in to change notification settings - Fork 0
π‘οΈ Sentinel: [HIGH] Fix SSRF in web E2E readiness probe #1342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
seonghobae
wants to merge
7
commits into
main
from
sentinel/fix-ssrf-sandboxed-web-e2e-14288601847491184394
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9912779
π‘οΈ [HIGH] Fix SSRF vulnerability in web e2e readiness probe\n\nScriptβ¦
seonghobae d723610
Merge branch 'main' into sentinel/fix-ssrf-sandboxed-web-e2e-14288601β¦
seonghobae bf888fb
Merge branch 'main' into sentinel/fix-ssrf-sandboxed-web-e2e-14288601β¦
seonghobae 6182074
fix(security): require OS isolation for web e2e commands
seonghobae 92e3499
fix(security): harden loopback and document isolation
seonghobae 0a297c9
fix(security): mount isolated root filesystem
seonghobae 799b13f
π‘οΈ [HIGH] Fix SSRF vulnerability in web e2e readiness probe\n\nScriptβ¦
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 0 additions & 36 deletions
36
.github/workflows/contextual-orchestrator-hourly-review-repair.yml
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π DiskSage caller drops job-level id-token: write
Removing the job-level
permissionsblock leaves the reusable scheduler with only workflow-levelcontents: read. The OIDC OpenCode app-token exchange (.github/workflows/pr-review-fix-scheduler.yml:163-166) then hits its unavailable branch and drops that credential path. It does not break the run: the step exits 0 and continues on the forwarded tokens, andclearfolio-hourly-review-repair.ymlalready runs this way. The PR also deletes the test that required id-token for disksage, so the change is self-consistent. Confirm the lost OIDC fallback is intended, since this PR is nominally an SSRF fix.Was this helpful? React with π or π to provide feedback.