fix(strix): bound retry budget and retain attempt logs by seonghobae · Pull Request #1333 · ContextualWisdomLab/.github

seonghobae · 2026-08-25T12:20:41Z

Replacement for #1332

This current-main replacement retains the bounded provider-outage retry behavior and fixes the exact-head review findings:

Reserves the complete trusted gate budget plus backoff before launching another attempt, so GitHub's 100-minute step timeout cannot kill a late retry before terminal classification.
Keeps each attempt in a distinct log and appends all attempts to the uploaded console artifact; terminal classification still scopes only the final attempt.
Preserves fail-closed behavior for findings, configuration failures, and unexpected exits.
Adds executable contract coverage for the retry budget/log retention and the exempted-finding/provider-outage cases.

Local checks:

8 focused pytest tests
targeted Ruff, shell syntax, trusted Strix smoke, and git diff --check

Re-uploaded after the requested close-and-new workflow; based on #1332's current head 495c02d plus the bounded review fixes.

Transient LLM provider outages (rate limits, connection/warm-up failures, ModelBehaviorError) previously failed the required strix check on the first attempt even when no vulnerability was reported, forcing manual reruns of the whole PR queue. The gate now retries such typed outages up to 3 attempts with linear backoff inside a deterministic SECONDS-based deadline (100 min cap, >=10 min remaining required to retry), all inside the existing 120-minute job budget. Genuine vulnerability reports, configuration failures (exit 2), and unexpected exit codes never retry; every terminal outcome remains fail-closed. Signal patterns are defined before the loop and the post-loop classification is unchanged.

…ed gate - Update stale model assertions from the nonexistent gpt-5.6-luna to the shipped openai-direct/gpt-5.4 fallback (left stale by a724582). - Rework the backend-unavailable tail-scoping test to extract the neutralization/classification block (post-retry) and inject the canonical signal definitions, matching the bounded provider-outage retry loop added for the STRIX_PROVIDER_UNAVAILABLE failure class.

…iew pool Follows a724582's finding that gpt-5.6-luna 404s on the OpenAI API: the dispatch workflow still routed the review agent through that candidate, guaranteeing one wasted attempt per cycle and failing the exact-head-path policy assertions that already expected openai/gpt-5.4. Rename the embedded openai-direct catalog entry to gpt-5.4, update the pool string and the rationale comments.

…tract pool with gpt-5.4 The dispatch workflow's openai-direct slot is now gpt-5.4 (a724582: luna 404s), so update REVIEW_DISPATCH_BLOB_SHA to the recomputed blob hash and align the agent-contract candidate list/expectations.

CodeRabbit review finding: the bounded retry loop inspected the full console log while the terminal classification scopes to the tail after the last pipeline-continuation marker. An already-exempted finding before the marker therefore suppressed retries of a genuine later outage. The loop now computes the same continuation-marker scope per attempt for both the reported- vulnerability and backend/model-error checks; terminal classification is unchanged. Adds STRIX_GATE_RETRY_BACKOFF_SECONDS (default 90) so tests can exercise the loop without real sleeps, plus regression coverage for recovery after an exempted finding and zero-retry on a real tail finding.

coderabbitai · 2026-08-25T12:20:50Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b6e53347-974f-4262-a8f3-2dbb2740297f

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

seonghobae · 2026-08-25T12:22:39Z

Exact-current-head evidence: 402f64adf3a377326505f5d48098666d8d8f92d5 on protected base d2c554dbbc04854db6215970fabb70cef1ceb690. Local 8-test retry contract, Ruff, shell syntax, trusted smoke, and diff checks pass; hosted checks and independent approval remain required.

devin-ai-integration

Devin Review found 1 potential issue.

devin-ai-integration

Devin Review found 2 new potential issues.

devin-ai-integration

Devin Review found 1 new potential issue.

seonghobae · 2026-08-25T12:41:26Z

Exact-head TDD evidence for 058e603365fd8219635fa96c6470de775e64d551 on protected base d2c554dbbc04854db6215970fabb70cef1ceb690:

RED: run 32847843077/job 97801678180 checked out predecessor 3230ffa6a4af60a8031bdedb8a4436948446c629 and failed exactly the two retry-loop fixtures with Bash exit 127 because the extracted production region used budget_suffix under set -u while the harness omitted the production initialization.
Narrow fix: initialize budget_suffix=TIMEOUT in the fixture; production retry/classification behavior was unchanged.
GREEN: run 32848187491/job 97802684800 checked out exact head 058e603365fd8219635fa96c6470de775e64d551, passed 1,421 tests plus 16 subtests, and completed test_strix_quick_gate: PASS.
Current unresolved review threads: zero after resolving the repaired RED finding and verified informational observations.

Security/CodeQL/SBOM workflows and an independent exact-current-head formal verdict remain required; this comment does not treat pending evidence as passing.

seonghobae · 2026-08-25T13:14:04Z

Exact-head evidence for 058e603365fd8219635fa96c6470de775e64d551: remote retry-budget fixture commits were fetched and the focused contract suite, Ruff, shell syntax, and diff checks pass locally. No unresolved non-outdated review threads are present. Hosted required checks are queued/running; the provider-outage path remains fail-closed and no merge is claimed until exact-head checks and independent non-author approval are present.

seonghobae · 2026-08-25T16:02:56Z

Current-head verification

Exact head SHA: 3fff51ce1a7dfc8d143492d2b18429a936bcbd45
Exact base SHA: 95b05b393c75931044b405ae491079d336d89293
The retry loop is bounded to three provider-outage attempts, preserves every attempt log, never retries reported vulnerabilities, and remains fail-closed for incomplete scans.
Exact-head local verification: 54 passed Strix/provider tests and git diff --check.
Hosted required Checks are still queued/in progress; no predecessor evidence is reused. Protected auto-merge remains enabled and no bypass is used.

seonghobae · 2026-08-25T16:13:59Z

Exact-head maintenance audit

Exact head: 3fff51ce1a7dfc8d143492d2b18429a936bcbd45
Exact base: 95b05b393c75931044b405ae491079d336d89293
Local focused verification: 54 passed; merge-conflict and diff checks passed.
Current hosted evidence is bound to this exact head; queued checks and absent approval remain normal protected-gate states.
The PR remains on protected squash auto-merge; no bypass, fake status, or approval was used.

The exact-head OpenCode review dispatch was requested.

seonghobae added 8 commits August 25, 2026 14:47

fix(strix): bound provider outage retries

e6e5f85

test(strix): remove inert retry helper branch

495c02d

fix(strix): bound retry budget and retain attempt logs

402f64a

seonghobae mentioned this pull request Aug 25, 2026

fix(strix): bounded provider-outage retries #1332

Closed

devin-ai-integration Bot reviewed Aug 25, 2026

View reviewed changes

Comment thread .github/workflows/strix.yml

seonghobae added 2 commits August 25, 2026 05:28

fix(strix): hide indirect timeout budget name

c1a90de

test(strix): bind indirect retry budget contract

3230ffa

devin-ai-integration Bot reviewed Aug 25, 2026

View reviewed changes

Comment thread tests/test_strix_backend_unavailable_after_exempted_finding.py

Comment thread tests/test_pr_review_autofix_nvidia_nim_contract.py

test(strix): initialize retry budget suffix fixture

058e603

devin-ai-integration Bot reviewed Aug 25, 2026

View reviewed changes

Comment thread .github/workflows/strix.yml

seonghobae enabled auto-merge (squash) August 25, 2026 14:23

Merge branch 'main' into fix/strix-provider-outage-bounded-retry-v3

3fff51c

Merge branch 'main' into fix/strix-provider-outage-bounded-retry-v3

5454a19

seonghobae merged commit e3b7ece into main Aug 25, 2026
51 checks passed

seonghobae deleted the fix/strix-provider-outage-bounded-retry-v3 branch August 25, 2026 18:59

This was referenced Aug 25, 2026

fix(strix): serialize scans and resolve live NVIDIA NIM models #1297

Merged

fix(strix): bare Fatal/Denied/Warn/Warning match lacks provider-context guard, causing false-positive fail-closed on clean scans #1291

Open

Navigation Menu

Uh oh!

fix(strix): bound retry budget and retain attempt logs - #1333

fix(strix): bound retry budget and retain attempt logs#1333
seonghobae merged 13 commits into
mainfrom
fix/strix-provider-outage-bounded-retry-v3

seonghobae commented Aug 25, 2026 •

edited by devin-ai-integration Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 25, 2026 •

edited

Loading

Uh oh!

seonghobae commented Aug 25, 2026

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

Uh oh!

seonghobae commented Aug 25, 2026

Uh oh!

seonghobae commented Aug 25, 2026

Uh oh!

seonghobae commented Aug 25, 2026

Uh oh!

seonghobae commented Aug 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

seonghobae commented Aug 25, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Replacement for #1332

Uh oh!

coderabbitai Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seonghobae commented Aug 25, 2026

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

seonghobae commented Aug 25, 2026

Uh oh!

seonghobae commented Aug 25, 2026

Uh oh!

seonghobae commented Aug 25, 2026

Current-head verification

Uh oh!

seonghobae commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Exact-head maintenance audit

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

seonghobae commented Aug 25, 2026 •

edited by devin-ai-integration Bot

Loading

coderabbitai Bot commented Aug 25, 2026 •

edited

Loading

seonghobae commented Aug 25, 2026 •

edited

Loading