feat(hourly): onboard appguardrail + macos_utility_packs review-repair callers - #1326
feat(hourly): onboard appguardrail + macos_utility_packs review-repair callers#1326seonghobae wants to merge 5 commits into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…-5.4 emission Commit a724582 moved strix.yml's direct-OpenAI fallback from the nonexistent gpt-5.6-luna to gpt-5.4 and aligned the smoke contracts, but missed this call-site in test_required_workflow_queue_contract.py, so main's required gate red-flagged every PR (seen on #1326). Assert the emitted gpt-5.4 per the current workflow contract.
|
Warning Review limit reachedNext included review available in 28 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAppGuardrail과 macOS Utility Packs에 시간별 PR 리뷰 수리 워크플로를 추가했습니다. 두 호출자의 운영 문서와 계약 테스트를 추가했습니다. 품질 경로와 Changes시간별 리뷰 수리 호출자
OpenAI 모델 fallback 변경
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: 🟡 Moderate · up to The PR adds two hourly callers but also leaves the model fallback configuration inconsistent with the registered provider models and existing required checks, which can cause dispatch validation failures and incorrect runtime configuration. Merge is not ready until the model configuration and related contracts are aligned; the documentation citation issue is minor and localized. Sequence Diagram(s)sequenceDiagram
participant HourlyCaller
participant ReviewFixScheduler
participant TargetRepository
HourlyCaller->>ReviewFixScheduler: 시간별 리뷰 수리 작업 호출
ReviewFixScheduler->>TargetRepository: develop 대상 열린 PR 조회
ReviewFixScheduler->>TargetRepository: 최대 하나의 제한된 수리 디스패치
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 22 functions across 4 files. (6 skipped: 6 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Current-head review repairFixed the valid current-head findings:
The provider definition was already present at the reviewed head, so that earlier finding was stale and required no duplicate source change. Devin informational roster/path-filter notes are pre-existing documentation scope and do not affect the two new caller minutes; they remain recorded for the next roster-contract increment. Exact-head validation: full central suite |
…s (minute 44) callers - Thin hourly callers delegate to pr-review-fix-scheduler with develop bases, single dispatch, and two-hour same-head retry floors. - appguardrail fills its long-reserved roster slot; macos_utility_packs takes a fresh non-colliding minute. - Doctoring records activation prerequisites incl. the OPENCODE_REPOSITORY_DISPATCH_TARGETS allowlist entries (set at org level in the same change window) with APA 7th references. - Focused contract tests mirror the established trio; quality gate pull/push/compileall path blocks track all six files.
…provider base URL resolved_llm_api_base_for_model had cross-provider handling only for github_models/* fallbacks. When the primary provider was nvidia_nim (or any provider that sets LLM_API_BASE), openai-direct/gpt-5.4 fallback attempts inherited the NVIDIA inference endpoint while carrying the OpenAI key, so litellm posted to the wrong host and every attempt died with 'Error: 404 page not found' (STRIX_PROVIDER_UNAVAILABLE). Direct OpenAI attempts now resolve to no custom base so litellm routes to api.openai.com by default (#1327).
397a682 to
19f323d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
# Conflicts: # .github/workflows/opencode-review-dispatch.yml # tests/test_pr_review_autofix_nvidia_nim_contract.py
| uses: ./.github/workflows/pr-review-fix-scheduler.yml | ||
| with: | ||
| target_repository: ContextualWisdomLab/appguardrail | ||
| base_branch: develop |
There was a problem hiding this comment.
🔍 base_branch develop differs from sibling callers
Both new callers use base_branch: develop, whereas every existing caller uses master/main. The doctoring documents develop consistently, so this reads as intentional, but it depends on the target repos actually protecting develop and on OPENCODE_REPOSITORY_DISPATCH_TARGETS being updated out-of-band.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Summary
hourly-nvidia-nim-review-repairpull/push/compileall path blocks now track all six files.OPENCODE_REPOSITORY_DISPATCH_TARGETSupdated out-of-band to include both targets (activation prerequisite documented in doctoring).Test plan
pytest tests/test_appguardrail_hourly_review_caller.py tests/test_macos_utility_packs_hourly_review_caller.py tests/test_nonnest2_hourly_review_caller.py tests/test_afipc_hourly_review_caller.py tests/test_pr_review_fix_hourly_contract.py→ 41 passedSummary by CodeRabbit
새 기능
개선
gpt-5.4로 변경되었습니다.테스트