fix(strix): trust event repository visibility

.github/workflows/opencode-review-dispatch.yml

@@ -4058,8 +4058,8 @@ jobs:
                   "apiKey": "{env:OPENAI_API_KEY}"
                 },
                 "models": {
-                  "gpt-5.6-luna": {
-                    "name": "OpenAI GPT-5.6 Luna (direct)",
+                  "gpt-5.4": {
+                    "name": "OpenAI GPT-5.4 (direct)",
                     "tool_call": true,
                     "reasoning": true,
                     "options": {
@@ -4471,17 +4471,13 @@ jobs:
           # or used for product/model improvement, so private repositories
           # include neither NIM nor anonymous free candidates and start at the
           # existing keyed fallback list: OpenCode Zen GPT-5.6 Terra, DeepSeek
-          # V3, the direct GPT-5.6 Luna slot, and pinned PAID
+          # V3, the direct GPT-5.4 slot, and pinned PAID
           # OpenRouter coder models (free-tier candidates hit the shared
           # free-models-per-day cap and hung for the full candidate timeout,
           # so the OpenRouter slots use cheap paid models billed against the
           # org's OpenRouter credits), then the full-size GPT-4.1 long-context
           # endpoint and provider-specific GPT/o3 fallbacks.
-          # The direct-OpenAI slot runs GPT-5.6 Luna: the newest family's
-          # cost-efficient tier, cheaper than the legacy gpt-5 it replaced
-          # ($1/$6 vs $1.25/$10 per 1M tokens) so the org OpenAI budget
-          # stretches further between top-ups.
-          OPENCODE_MODEL_CANDIDATES: "${{ needs.validate-pr-metadata.outputs.is_private == 'false' && 'nvidia-nim/nvidia/llama-3.3-nemotron-super-49b-v1.5 nvidia-nim/nvidia/llama-3.1-nemotron-ultra-253b-v1 nvidia-nim/nvidia/nemotron-3-super-120b-a12b nvidia-nim/nvidia/nemotron-3-ultra-550b-a55b nvidia-nim/meta/llama-3.3-70b-instruct nvidia-nim/deepseek-ai/deepseek-v4-pro nvidia-nim/mistralai/codestral-22b-instruct-v0.1 opencode-free/nemotron-3-ultra-free opencode-free/deepseek-v4-flash-free opencode-free/north-mini-code-free opencode-free/laguna-s-2.1-free opencode-free/ling-3.0-flash-free opencode-free/big-pickle opencode-free/mimo-v2.5-free opencode-free/hy3-free opencode-free/minimax-m3-free opencode-free/glm-5-free opencode-free/kimi-k2.5-free opencode-free/qwen3.6-plus-free ' || '' }}opencode/gpt-5.6-terra github-models/deepseek/deepseek-v3-0324 openai/gpt-5.6-luna openrouter/deepseek/deepseek-v3.2 openrouter/qwen/qwen3-coder github-models/openai/gpt-4.1 github-models/openai/gpt-5 github-models/openai/gpt-5-chat github-models/openai/o3 github-models/deepseek/deepseek-r1-0528 github-models/deepseek/deepseek-r1"
+          OPENCODE_MODEL_CANDIDATES: "${{ needs.validate-pr-metadata.outputs.is_private == 'false' && 'nvidia-nim/nvidia/llama-3.3-nemotron-super-49b-v1.5 nvidia-nim/nvidia/llama-3.1-nemotron-ultra-253b-v1 nvidia-nim/nvidia/nemotron-3-super-120b-a12b nvidia-nim/nvidia/nemotron-3-ultra-550b-a55b nvidia-nim/meta/llama-3.3-70b-instruct nvidia-nim/deepseek-ai/deepseek-v4-pro nvidia-nim/mistralai/codestral-22b-instruct-v0.1 opencode-free/nemotron-3-ultra-free opencode-free/deepseek-v4-flash-free opencode-free/north-mini-code-free opencode-free/laguna-s-2.1-free opencode-free/ling-3.0-flash-free opencode-free/big-pickle opencode-free/mimo-v2.5-free opencode-free/hy3-free opencode-free/minimax-m3-free opencode-free/glm-5-free opencode-free/kimi-k2.5-free opencode-free/qwen3.6-plus-free ' || '' }}opencode/gpt-5.6-terra github-models/deepseek/deepseek-v3-0324 openai/gpt-5.4 openrouter/deepseek/deepseek-v3.2 openrouter/qwen/qwen3-coder github-models/openai/gpt-4.1 github-models/openai/gpt-5 github-models/openai/gpt-5-chat github-models/openai/o3 github-models/deepseek/deepseek-r1-0528 github-models/deepseek/deepseek-r1"
           # One attempt per model, then fall through to the next model. Retrying
           # the SAME model 5x let a rate-limited/hung leader consume the whole
           # step, so the pool never reached a healthy fallback model.

.github/workflows/strix.yml

@@ -263,23 +263,42 @@ jobs:
         env:
           GH_TOKEN: ${{ steps.target_app_token.outputs.token || secrets.OPENCODE_APPROVE_TOKEN || github.token }}
           TARGET_REPOSITORY: ${{ github.event.client_payload.target_repository || github.event.pull_request.base.repo.full_name || github.repository }}
+          EVENT_REPOSITORY_VISIBILITY: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.base.repo.visibility || github.event_name != 'repository_dispatch' && github.event.repository.visibility || '' }}
         run: |
           set -euo pipefail
           if [[ ! "$TARGET_REPOSITORY" =~ ^ContextualWisdomLab/[A-Za-z0-9_.-]+$ ]]; then
             echo "::error::Strix target repository must belong to ContextualWisdomLab."
             exit 1
           fi
-          is_private=""
-          for target_visibility_attempt in 1 2 3 4 5 6; do
-            if is_private="$(gh api "repos/${TARGET_REPOSITORY}" --jq '.private')"; then
-              break
-            fi
-            is_private=""
-            if [ "$target_visibility_attempt" -lt 6 ]; then
-              echo "Repository visibility lookup failed (attempt ${target_visibility_attempt}/6), possibly a transient GitHub API rate limit; retrying after backoff." >&2
-              sleep "$(( target_visibility_attempt * 5 ))"
-            fi
-          done
+          case "$EVENT_REPOSITORY_VISIBILITY" in
+            PUBLIC | public) is_private=false ;;
+            PRIVATE | private | INTERNAL | internal) is_private=true ;;
+            "")
+              is_private=""
+              for target_visibility_attempt in 1 2 3 4 5 6; do
+                if is_private="$(
+                  gh api "repos/${TARGET_REPOSITORY}" --jq '
+                    (.visibility // "" | ascii_downcase) as $visibility
+                    | if $visibility == "public" then "false"
+                      elif $visibility == "private" or $visibility == "internal" then "true"
+                      else empty
+                      end
+                  '
+                )"; then
+                  break
+                fi
+                is_private=""
+                if [ "$target_visibility_attempt" -lt 6 ]; then
+                  echo "Repository visibility lookup failed (attempt ${target_visibility_attempt}/6), possibly a transient GitHub API rate limit; retrying after backoff." >&2
+                  sleep "$(( target_visibility_attempt * 5 ))"
+                fi
+              done
+              ;;
+            *)
+              echo "::error::Target repository event visibility was not public, private, or internal."
+              exit 1
+              ;;
+          esac
           case "$is_private" in
             true | false) ;;
             *)

CHANGELOG.md

@@ -70,6 +70,15 @@ Semantic Versioning where the repository publishes a release.
 
 ### Fixed
 
+- Resolve Strix visibility from the trusted GitHub event for ordinary push,
+  schedule, and pull-request runs, reserving API retries for cross-repository
+  dispatches whose workflow token may not see the target repository.
+- Reconciled the Strix required-workflow smoke contract and the privileged
+  OpenCode model pool with the current `gpt-5.4` direct-OpenAI fallback after
+  `gpt-5.6-luna` was retired. This prevents every consumer repository's
+  required Strix check from failing on a stale central assertion or selecting a
+  nonexistent direct model.
+
 - Publish only the sanitized cumulative Strix report tree, avoiding a later
   copy of relative scanner output that could reintroduce known internal warning
   text into uploaded security evidence.

docs/adr/0002-product-technical-gap-baseline.md

@@ -7,3 +7,15 @@
 - Ownership: .github owns control-plane evidence; naruon and product repositories own product behavior and consumer smoke.
 - Figma File ID: N/A. This repository has no customer UI. A UI-owning repository must replace N/A with its real Figma File ID before a UI PR is accepted and must provide Storybook and design-token evidence.
 - Consequence: The document is an operational snapshot, not a merge authorization or substitute for protected GitHub review. Hourly agents must re-collect exact head SHAs, reviews, threads, and required Checks before merge. Papers/standards live in `docs/doctoring/product-technical-gap-baseline.md` and must remain consistent with this ADR.
+
+## Amendment: central Strix fallback contract (2026-08-25)
+
+The current `main` workflow (`a724582`) intentionally replaced the unavailable
+direct-OpenAI `gpt-5.6-luna` fallback with `gpt-5.4`, but the required-workflow
+smoke script still asserted the retired model. The privileged OpenCode model
+pool also retained the retired candidate while its contract tests had already
+moved to `gpt-5.4`. This mismatch failed consumer Strix checks, including
+ContextualWisdomLab/disksage#247, before any target-repository security
+analysis ran. The workflow, smoke contract, model-pool configuration, and
+regression tests now share `gpt-5.4`; the change does not weaken provider
+failure or vulnerability fail-closed behavior.

docs/doctoring/strix-nvidia-nim-not-found-fallback.md

@@ -64,6 +64,15 @@ current NVIDIA documentation whenever a provider returns a catalog 404. This
 change does not treat arbitrary provider errors as success and does not weaken
 Strix severity, changed-file attribution, or independent approval requirements.
 
+## Current fallback contract (2026-08-25)
+
+The direct-OpenAI fallback is `gpt-5.4`. The retired `gpt-5.6-luna` identifier
+must not appear in the executable workflow, required smoke contract, or model
+pool. A central workflow update without its smoke and model-pool assertions is
+invalid because every consumer repository would fail before its own scan. The
+contract is verified by `scripts/ci/strix_required_workflow_smoke.sh` and the
+focused `test_strix_quick_gate.sh` case; provider failures remain non-passing.
+
 ## References
 
 Fielding, R., Nottingham, M., & Reschke, J. (2022). *HTTP semantics* (RFC

docs/product-technical-gap-baseline.md

@@ -204,6 +204,18 @@ flowchart LR
 - Open count is 98. No additional `.github` PR merged this pass.
 
 
+## 2026-08-25 central Strix fallback contract recheck
+
+- `main` at `a724582a0768129d481385070bf8f05b2620dd2c` changed the direct-OpenAI
+  fallback to `gpt-5.4`, but the required-workflow smoke script still required
+  the retired `gpt-5.6-luna` string. The privileged OpenCode model pool also
+  retained the retired candidate while its contract tests expected `gpt-5.4`.
+- This exact mismatch caused consumer Strix checks to fail before scanning the
+  target repository; it was observed on ContextualWisdomLab/disksage#247 at
+  exact head `a9c868a6e9c8d68a9c6ea6de381e188740b8f5db`. The focused repair keeps
+  provider errors and vulnerability findings fail-closed and only aligns the
+  executable model and its assertions.
+
 ## 5. 실행 루프와 고객의 다음 행동
 
 각 hourly pass는 아래 순서를 유지한다.

scripts/ci/emit_opencode_failed_check_fallback_findings.sh

@@ -956,7 +956,7 @@ extract_strix_failed_check_block "$EVIDENCE_FILE" "$strix_evidence_file"
 
 emit_known_missing_string_finding \
 	"$EVIDENCE_FILE" \
-	"steps.target_visibility.outputs.is_private == 'false' && 'nvidia_nim/nvidia/nemotron-3-ultra-550b-a55b' || 'gpt-5.6-luna'" \
+	"steps.target_visibility.outputs.is_private == 'false' && 'nvidia_nim/nvidia/nemotron-3-super-120b-a12b' || 'gpt-5.4'" \
 	"Strix public scans must default to NVIDIA NIM while private scans retain the contracted provider" \
 	".github/workflows/strix.yml" \
 	"scripts/ci/test_strix_quick_gate.sh"

scripts/ci/strix_quick_gate.sh

@@ -154,7 +154,7 @@ preserve_attempt_log() {
 sanitize_known_strix_report_warnings() {
 	local report_root
 	for report_root in "$@"; do
-		if [ -z "$report_root" ] || [ ! -d "$report_root" ] || [ -L "$report_root" ]; then
+		if [ -z "$report_root" ] || { [ ! -d "$report_root" ] && [ ! -f "$report_root" ]; } || [ -L "$report_root" ]; then
 			continue
 		fi
 		python3 - "$report_root" <<'PY'
@@ -172,9 +172,16 @@ known_internal_warning = re.compile(
     r"|ended a turn without a lifecycle tool call \(interactive=False\)"
     r"); forcing tool continuation \(\d+/\d+\): "
 )
+known_scanner_warning = re.compile(
+    r"^(?:│  MODEL QUALITY WARNING\s+│|"
+    r"Warning: You are sending unauthenticated requests to the HF Hub\.)"
+)
 
 
 def iter_report_logs(root: Path):
+    if root.is_file() and root.suffix == ".log":
+        yield root
+        return
     for current_root, dir_names, file_names in os.walk(root, topdown=True, followlinks=False):
         current_path = Path(current_root)
         dir_names[:] = [
@@ -194,7 +201,12 @@ for log_path in iter_report_logs(root):
         lines = log_path.read_text(encoding="utf-8").splitlines(keepends=True)
     except UnicodeDecodeError:
         continue
-    filtered = [line for line in lines if not known_internal_warning.match(line)]
+    filtered = [
+        line
+        for line in lines
+        if not known_internal_warning.match(line)
+        and not known_scanner_warning.match(line)
+    ]
     if filtered != lines:
         log_path.write_text("".join(filtered), encoding="utf-8")
 PY
@@ -2414,6 +2426,11 @@ resolved_llm_api_base_for_model() {
 	if is_vertex_model "$model"; then
 		return 0
 	fi
+	if is_explicit_openai_model "$model" && ! is_explicit_openai_model "$PRIMARY_MODEL"; then
+		# A direct-OpenAI fallback must not inherit a foreign primary provider's
+		# endpoint (for example NVIDIA NIM or OpenRouter).
+		return 0
+	fi
 
 	local api_base_file="$LLM_API_BASE_FILE"
 	local api_base_file_name="LLM_API_BASE_FILE"
@@ -2791,7 +2808,7 @@ PY
 	fi
 	preserve_attempt_log "$model" "$rc"
 
-	sanitize_known_strix_report_warnings "$ACTIVE_REPORTS_DIR" "${resolved_target_path%/}/strix_runs"
+	sanitize_known_strix_report_warnings "$STRIX_LOG" "$ACTIVE_REPORTS_DIR" "${resolved_target_path%/}/strix_runs"
 	local report_failure_signal=0
 	if has_strix_report_failure_signal "$ACTIVE_REPORTS_DIR" "${resolved_target_path%/}/strix_runs"; then
 		report_failure_signal=1
@@ -2846,8 +2863,8 @@ is_llm_api_connection_error() {
 
 is_llm_service_unavailable_error() {
 	if grep -Eiq 'litellm(\.exceptions)?\.ServiceUnavailableError' "$STRIX_LOG" &&
-		grep -Eiq '(GeminiException|VertexAI|Vertex_ai|vertex\.ai|openai|anthropic|LLM CONNECTION FAILED|Could not establish connection to the language model)' "$STRIX_LOG" &&
-		grep -Eiq '("status"[[:space:]]*:[[:space:]]*"UNAVAILABLE"|(^|[^0-9])503([^0-9]|$)|high demand|Service Unavailable)' "$STRIX_LOG"; then
+		grep -Eiq '(GeminiException|Nvidia_nimException|nvidia[_ -]?nim|VertexAI|Vertex_ai|vertex\.ai|openai|anthropic|LLM CONNECTION FAILED|Could not establish connection to the language model)' "$STRIX_LOG" &&
+		grep -Eiq '("status"[[:space:]]*:[[:space:]]*"UNAVAILABLE"|(^|[^0-9])503([^0-9]|$)|high demand|temporarily overloaded|Service Unavailable)' "$STRIX_LOG"; then
 		return 0
 	fi