Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/security-scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ jobs:
if len(findings) > 50:
print(f"... {len(findings) - 50} additional {label} OSV finding(s) omitted from the log summary.")
- name: Report PR-introduced OSV findings
uses: google/osv-scanner-action/osv-reporter-action@8dc09193bb540e09b23da07ad7e30bd33bf87018 # v2.3.8
uses: google/osv-scanner-action/osv-reporter-action@ffa0a5f39214d80778c9b494822d94d0d9668458 # v2.3.8

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Misleading version comment on bumped reporter pin

The reporter pin is bumped to ffa0a5f, which the PR's own commit list identifies as v2.5.1, but the trailing comment still reads # v2.3.8. The scanner-action steps remain pinned to v2.3.8, so the annotation is wrong and the reporter and scanner now run different versions.

Suggested change
uses: google/osv-scanner-action/osv-reporter-action@ffa0a5f39214d80778c9b494822d94d0d9668458 # v2.3.8
uses: google/osv-scanner-action/osv-reporter-action@ffa0a5f39214d80778c9b494822d94d0d9668458 # v2.5.1
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

with:
scan-args: |
--output=results.sarif
Comment on lines +192 to 195

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Reporter now newer than the scanner it consumes

The bumped reporter (v2.5.1 per ffa0a5f) reads JSON produced by scanner-action steps still pinned to v2.3.8. One bumped commit is "Fix JSON results export". Confirm the newer reporter still parses the older scanner's --old/--new JSON, since a format mismatch could break the vulnerability gate.

(Refers to this code)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Expand Down
Loading