fix(noema): fail closed at the credential egress boundary

[seonghobae]

Outcome

Replaces the conflicted and scope-polluted #930 with a clean current-main change.

• requires HTTPS for every non-loopback model endpoint
• resolves the effective host and port before constructing the credentialed request
• rejects resolver failures, empty or malformed answers, and every non-global or multicast address
• requires exact pre/post-request DNS-set equality
• bounds provider responses to 1 MiB before JSON decoding
• keeps redirect refusal and the existing Wire Noema to a same-job contextual-orchestrator sidecar #1120 same-job sidecar seam, restricted to literal 127.0.0.1 and ::1

This PR does not import contextual-orchestrator, alter provider routing, change model selection, or modify model parameters.

Evidence

• 1,419 passed, 1 skipped, 16 subtests passed
• 8,378 statements and 3,228 branches at 100%
• scripts/ci docstrings: 100%
• compileall and git diff --check: pass
• APA 7th doctoring records OWASP SSRF guidance, RFC 6890, CWE-400, and CWE-918, including the residual DNS/socket TOCTOU boundary

Supersedes #930. Preserves the trusted loopback consumer contract from #1120.

---

[coderabbitai]

Warning

Review limit reached

Next included review available in 32 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 115936b9-fd14-4408-a571-2db53505dc97

📥 Commits

Reviewing files that changed from the base of the PR and between 613a33e and 721a36f.

📒 Files selected for processing (6)

• CHANGELOG.md
• docs/doctoring/noema-credential-egress-boundary.md
• scripts/ci/noema_review_gate.py
• tests/test_noema_endpoint_boundary.py
• tests/test_noema_review_gate.py
• tests/test_repository_branch_coverage_review_schedulers.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[opencode-agent]

Pull request overview

OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.

Findings

1. HIGH Current-head GitHub Checks - Fix failed required checks before approval

• Problem: Failed same-head checks remain for b19c5b452cf53a5b5a85d9805efaa1899cf0a04b.
• Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
• Fix: Read and fix the failed check logs below, then rerun the current-head checks.
• Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.

Failed checks:

• Strix Security Scan/strix: FAILURE (https://github.com/ContextualWisdomLab/.github/actions/runs/32661188447/job/97250595093)
• Strix Security Scan/strix: failure (https://github.com/ContextualWisdomLab/.github/actions/runs/32661188447/job/97250595093)

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file: CHANGELOG.md"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file: CHANGELOG.md"]
  R1 --> V1["required checks"]
  Evidence --> S2["Docs: noema-credential-egress-boundary.md"]
  S2 --> I2["operator or user guidance"]
  I2 --> R2["Review risk: Docs: noema-credential-egress-boundary.md"]
  R2 --> V2["docs review"]
  Evidence --> S3["CI script: noema_review_gate.py"]
  S3 --> I3["review and security gate shell path"]
  I3 --> R3["Review risk: CI script: noema_review_gate.py"]
  R3 --> V3["bash -n plus Strix self-test"]
  Evidence --> S4["Test (3 files)"]
  S4 --> I4["regression suite"]
  I4 --> R4["Review risk: Test (3 files)"]
  R4 --> V4["targeted test run"]

Loading

[opencode-agent]

OpenCode Review Overview

• Head SHA: 721a36f24616343029a291f02db32610f470a884
• Workflow run: 32746125713
• Workflow attempt: 1
• Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.

Findings

1. HIGH Current-head GitHub Checks - Fix failed required checks before approval

• Problem: Failed same-head checks remain for 721a36f24616343029a291f02db32610f470a884.
• Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
• Fix: Read and fix the failed check logs below, then rerun the current-head checks.
• Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.

Failed checks:

• Strix Security Scan/strix: FAILURE (https://github.com/ContextualWisdomLab/.github/actions/runs/32723348685/job/97419259259)
• Strix Security Scan/strix: failure (https://github.com/ContextualWisdomLab/.github/actions/runs/32723348685/job/97419259259)

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file: CHANGELOG.md"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file: CHANGELOG.md"]
  R1 --> V1["required checks"]
  Evidence --> S2["Docs: noema-credential-egress-boundary.md"]
  S2 --> I2["operator or user guidance"]
  I2 --> R2["Review risk: Docs: noema-credential-egress-boundary.md"]
  R2 --> V2["docs review"]
  Evidence --> S3["CI script: noema_review_gate.py"]
  S3 --> I3["review and security gate shell path"]
  I3 --> R3["Review risk: CI script: noema_review_gate.py"]
  R3 --> V3["bash -n plus Strix self-test"]
  Evidence --> S4["Test (3 files)"]
  S4 --> I4["regression suite"]
  I4 --> R4["Review risk: Test (3 files)"]
  R4 --> V4["targeted test run"]

Loading

[seonghobae]

Exact-head formal review request for 92c8b95. Inspect the complete current diff, especially Noema credential egress boundary, fail-closed behavior, and secret handling. Publish a substantive Reviews API verdict tied only to this exact SHA, with changed-file walkthrough, security/control-plane impact, test gaps, and residual uncertainty. Do not reuse predecessor evidence. @opencode-agent

[seonghobae]

Exact-head current identity is 92c8b95e5778dda51a60f483162be3ec40c2aa23. The prior Strix failure run 32692202410 is provider infrastructure only: repeated NVIDIA NIM 429 rate limits followed by direct fallback 404, with fail-closed no-report behavior. I reran the failed job normally. The pinned transport/SSRF change has no unresolved current thread; please publish a substantive exact-head review after the rerun. No bypass or merge until all required Checks and approval are current.

[seonghobae]

Exact-head validation after fixing the Devin IPv6 finding:

• Exact head: 721a36f24616343029a291f02db32610f470a884
• Exact base: 613a33e0cb1c6db9790fae99f6253445712ac37a
• Root cause fixed: _socket_target now passes validated IPv4 and IPv6 literals to socket.create_connection as (host, port). The prior IPv6 four-field tuple raises ValueError before connection and bypasses the OSError retry path.
• Regression coverage: test_pinned_connection_supports_ipv6_destination_shape now drives PinnedHTTPConnection.connect() and asserts the exact IPv6 target.
• Focused validation: 57 passed in tests/test_noema_endpoint_boundary.py, tests/test_noema_review_gate.py, and tests/test_repository_branch_coverage_review_schedulers.py.
• compileall, git diff --check, and clean-worktree checks passed.

The remaining TCP_NODELAY note is informational and does not affect credential routing or correctness; it is not being expanded into this bounded fix. Hosted checks and a fresh independent review are still pending, so this PR is not being merged or force-merged.

[opencode-agent]

Pull request overview

OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.

Findings

1. HIGH Current-head GitHub Checks - Fix failed required checks before approval

• Problem: Failed same-head checks remain for 721a36f24616343029a291f02db32610f470a884.
• Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
• Fix: Read and fix the failed check logs below, then rerun the current-head checks.
• Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.

Failed checks:

• Strix Security Scan/strix: FAILURE (https://github.com/ContextualWisdomLab/.github/actions/runs/32723348685/job/97419259259)
• Strix Security Scan/strix: failure (https://github.com/ContextualWisdomLab/.github/actions/runs/32723348685/job/97419259259)

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file: CHANGELOG.md"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file: CHANGELOG.md"]
  R1 --> V1["required checks"]
  Evidence --> S2["Docs: noema-credential-egress-boundary.md"]
  S2 --> I2["operator or user guidance"]
  I2 --> R2["Review risk: Docs: noema-credential-egress-boundary.md"]
  R2 --> V2["docs review"]
  Evidence --> S3["CI script: noema_review_gate.py"]
  S3 --> I3["review and security gate shell path"]
  I3 --> R3["Review risk: CI script: noema_review_gate.py"]
  R3 --> V3["bash -n plus Strix self-test"]
  Evidence --> S4["Test (3 files)"]
  S4 --> I4["regression suite"]
  I4 --> R4["Review risk: Test (3 files)"]
  R4 --> V4["targeted test run"]

Loading