-
Notifications
You must be signed in to change notification settings - Fork 0
fix(strix): retry exact model-quality warnings #1177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a6ab307
fix: retry Strix model quality warnings
seonghobae 843ee9a
Merge branch 'main' into codex/strix-min-severity-gate
opencode-agent[bot] 659b486
Merge branch 'main' into codex/strix-min-severity-gate
opencode-agent[bot] 4d397ea
fix(strix): bind model warning to provider detail
seonghobae bfb1854
Merge remote-tracking branch 'origin/main' into HEAD
seonghobae 07fa2a6
refactor(strix): remove redundant warning branch
seonghobae ad0e960
Merge branch 'main' into codex/strix-min-severity-gate
opencode-agent[bot] 5087f82
Merge branch 'main' into codex/strix-min-severity-gate
opencode-agent[bot] b2cdb96
test(strix): align scheduler contract with current concurrency
seonghobae 7787783
fix(security): refresh pip audit dependency
seonghobae 6ab0104
Merge branch 'main' into codex/strix-min-severity-gate
seonghobae f6c2404
test(coverage): document coordinator client initializer
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # Strix model-quality warning fallback | ||
|
|
||
| 검토 기준일: **2026-08-21** | ||
|
|
||
| ## Incident | ||
|
|
||
| The central Strix workflow selected the public-repository NVIDIA NIM model | ||
| `nvidia/nemotron-3-super-120b-a12b`. Strix completed a scan and produced only a | ||
| `LOW` finding, but it also emitted `MODEL QUALITY WARNING` because the selected | ||
| model was not a recommended frontier model. The gate correctly classified the | ||
| warning as non-clean evidence, then stopped before trying the configured | ||
| fallback models. This left an actionable low-severity report indistinguishable | ||
| from an unrecoverable provider failure and blocked the target pull request. | ||
|
|
||
| ## Decision | ||
|
|
||
| `scripts/ci/strix_quick_gate.sh` recognizes only Strix's exact model-quality | ||
| warning (`MODEL QUALITY WARNING` / `is not a recommended frontier model for | ||
| Strix`) as retryable model evidence. It remains an infrastructure/failure | ||
| signal, so the scan never passes merely because the warning was seen. The | ||
| existing fallback sequence must obtain a clean result or the gate fails closed. | ||
|
|
||
| All other `Warn`, `Warning`, `Fatal`, `Denied`, and `Timeout` output remains a | ||
| hard failure. A `MEDIUM` or higher vulnerability remains blocking even when a | ||
| fallback succeeds; below-threshold findings are handled by the existing | ||
| `STRIX_FAIL_ON_MIN_SEVERITY` policy. | ||
|
|
||
| ## Verification contract | ||
|
|
||
| `tests/test_strix_nvidia_nim_not_found_fallback.py` executes the production | ||
| classifier against a bounded quality-warning log and asserts that the warning | ||
| is wired into `is_model_retryable_error`. The existing shell harness continues | ||
| to cover generic warning signals and fallback failure paths. | ||
|
|
||
| ## Rollback | ||
|
|
||
| If a future Strix release changes the warning wording, add the exact new | ||
| provider-produced wording to the narrow classifier and its regression test. | ||
| Do not remove generic warning failure handling or neutralize the entire warning | ||
| class. | ||
|
|
||
| ## References (APA 7th) | ||
|
|
||
| GitHub. (n.d.). *Workflow syntax for GitHub Actions*. GitHub Docs. Retrieved | ||
| August 21, 2026, from | ||
| https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax | ||
|
|
||
| GitHub. (n.d.). *Using workflow run logs*. GitHub Docs. Retrieved August 21, | ||
| 2026, from https://docs.github.com/en/actions/how-tos/monitor-workflows/use-workflow-run-logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.