-
Notifications
You must be signed in to change notification settings - Fork 0
fix(opencode): split review surfaces, give NIM two hours, and remove GitHub Models #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
cd48d23
fix(opencode): keep product-file review when coverage gate fails
cursoragent 31b1592
test(opencode): pin dispatch blob and close surface coverage gaps
cursoragent 1841e18
fix(opencode): split status comment from review and keep model prose
cursoragent 09bc3ad
fix(opencode): give NIM two hours and drop Copilot-class pool winners
cursoragent 62f69f4
test(opencode): treat github-models as catalog-only, not pool winners
cursoragent 6b9725a
fix(opencode): restore coverage-blocked status and honest class diagrams
cursoragent 91f1447
test(opencode): retarget independent-reviewer dispatch blob pin
cursoragent 8d4d7ed
test(opencode): retarget Strix mermaid assertions to the Python surfaces
cursoragent 90eea34
fix(osv): stop 429 setup failures on the supplemental PR scan
cursoragent 80bd590
fix(opencode): remove GitHub Models and fail closed on NIM
cursoragent f05924c
docs(opencode): reserve fail-closed orchestrator URL path
cursoragent 6412387
fix(ci): satisfy main Strix smoke and wait out CodeQL 503s
cursoragent a0cf0ad
fix(ci): pass main Strix smoke and retry CodeQL init
cursoragent 8c17723
fix(ci): drop materializer subprocess and retry Noema 503s
cursoragent 26b72d6
fix(opencode): verify coverage identity, formal receipts, and Orgmetr…
cursoragent 13a9fb0
test(opencode): retarget independent-reviewer dispatch blob pin
cursoragent 2116038
test(opencode): close receipt, coverage-identity, and Noema branch gaps
cursoragent 8c9ebf6
fix(opencode): address CodeRabbit findings on #1052 review-governance…
seonghobae fe3ed2a
fix(ci): correct assert_file_contains needle escaping for nvidia-nim …
seonghobae ff803b1
fix(opencode): treat nvidia-nim Strix windows as known report models
cursoragent d0b8c99
docs: add missing __init__ docstrings pulled in from main's merge
seonghobae 453f900
fix(ci): keep retired fallback smoke lintable
seonghobae a4928c9
fix(opencode): remove unused GitHub Models permission
seonghobae e91db80
test(opencode): repin least-privilege review dispatch
seonghobae c97fa00
Merge branch 'main' into cursor/opencode-review-surfaces-1bda
opencode-agent[bot] fe83dc0
Merge branch 'main' into cursor/opencode-review-surfaces-1bda
opencode-agent[bot] 529311f
Merge branch 'main' into cursor/opencode-review-surfaces-1bda
opencode-agent[bot] 1af53c4
fix(codeql): retry head initialization outage
seonghobae cd24023
fix(ci): remove unused materializer import
seonghobae d2ab979
fix(coverage): bind Rust materializer to base SHA (#1190)
seonghobae 7b82aa4
fix(review): tolerate malformed Rust text
seonghobae ca7ab23
Merge branch 'main' into cursor/opencode-review-surfaces-1bda
opencode-agent[bot] 237df35
Merge branch 'main' into cursor/opencode-review-surfaces-1bda
opencode-agent[bot] 9b5dc3c
Merge branch 'main' into cursor/opencode-review-surfaces-1bda
opencode-agent[bot] 3fa76a2
test: align scheduler contract and audit runtime
seonghobae aa38b2d
chore(opencode): restore canonical pip lock ownership
seonghobae 561a4f3
test(noema): reproduce private NIM visibility leak
seonghobae 29ce7cd
fix(noema): keep private diffs off hosted NIM
seonghobae 04604f1
fix(noema): admit governed private review endpoint
seonghobae 98afe08
test(noema): cover private provider gate
seonghobae 5299d32
Merge protected main into OpenCode review owner
seonghobae 3c2b523
test(noema): cover invalid LLM hostname guard
seonghobae 0bdc79b
Merge main into OpenCode review owner
seonghobae f16acaa
Merge remote-tracking branch 'origin/main' into cursor/opencode-revie…
seonghobae 6d4915d
fix(strix): reconcile Luna-removal with main's own compat smoke-test …
seonghobae 84b4cab
Merge remote-tracking branch 'origin/main' into cursor/opencode-revie…
seonghobae 8f106a2
fix(coverage): install governed optional dependencies
seonghobae dfbf485
test(coverage): reject unsupported pnpm flag
seonghobae b10e20b
fix(review): slurp paginated coverage checks
seonghobae 4aa738a
test(review): cover multi-page check receipts
seonghobae 26c95bf
Merge remote-tracking branch 'origin/main' into cursor/opencode-revie…
seonghobae d01d68f
fix(opencode): preserve protected-main Strix contract
seonghobae d2629dc
test(ci): converge shared Strix and OpenCode quick-gate contracts
seonghobae 4cb0e6e
test(opencode): preserve NIM-only replacement coverage
seonghobae fdfff41
fix(strix): recognize the hyphenated openai-direct fallback alias
seonghobae 9147dcf
Merge remote-tracking branch 'origin/cursor/opencode-review-surfaces-…
seonghobae eed623e
fix(opencode): track live Strix default diagnostic
seonghobae 766080a
test(opencode): cover live Strix default diagnostic
seonghobae cf065af
Merge branch 'main' into cursor/opencode-review-surfaces-1bda
seonghobae 7403952
fix(review): classify root Rust tests as tests
seonghobae 31e1b64
Merge protected main into OpenCode review surfaces
seonghobae 8ea117c
fix(strix): remove shadowed direct OpenAI alias arm
seonghobae bf3c974
fix(opencode): hold predecessor Strix verdicts
seonghobae f3e43ef
fix(codeql): keep init single-shot
seonghobae 2767946
Merge protected main into OpenCode review surfaces
cursoragent da8f30c
test(strix): retarget live default and fallback pins to gpt-5.4
cursoragent 9783723
docs(strix): correct direct alias history
seonghobae abf47ce
Merge protected main into OpenCode review surfaces
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
docs/doctoring/opencode-contextual-orchestrator-sidecar.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # OpenCode → contextual-orchestrator sidecar (next step) | ||
|
|
||
| 검토 기준일: **2026-08-17** | ||
|
|
||
| ## Decision | ||
|
|
||
| GitHub Models stays unused. The intended long-term OpenCode provider is | ||
| ContextualWisdomLab/contextual-orchestrator, an OpenAI-compatible | ||
| `/v1/chat/completions` hub. Until that sidecar exists, central review keeps | ||
| **NIM-direct** as the default (`NVIDIA_NIM_API_KEY` → `NVIDIA_API_KEY`). | ||
| `COPILOT_GITHUB_TOKEN` is not introduced. | ||
|
|
||
| This pull request does not start the sidecar and does not block OriginWeave | ||
| #47 quality fixes or the 7200s NIM timeout on it. | ||
|
|
||
| ## Optional path already in dispatch | ||
|
|
||
| If `vars.CONTEXTUAL_ORCHESTRATOR_URL` is set, | ||
| `scripts/ci/attach_contextual_orchestrator_provider.py` attaches one | ||
| OpenAI-compatible `contextual-orchestrator` provider block to the isolated | ||
| catalog. The helper fails closed on GitHub Models hosts, embedded | ||
| credentials, non-http(s) URLs, and non-loopback `http`. Unset URL is a | ||
| no-op. Default `model` / `small_model` and `OPENCODE_MODEL_CANDIDATES` | ||
| stay NIM-direct. | ||
|
|
||
| ## Next step (do not do it in this PR) | ||
|
|
||
| 1. The review job starts a ContextualWisdomLab/contextual-orchestrator sidecar. | ||
| 2. The sidecar registers these five organization secrets into its KV: | ||
| NIM, NIM_SUB, OpenAI, OpenRouter, and Bytez. | ||
| 3. OpenCode talks only to that sidecar URL. It does not receive the five | ||
| upstream secrets and does not fall back to GitHub Models. | ||
|
|
||
| ## References | ||
|
|
||
| ContextualWisdomLab/contextual-orchestrator is the org LLM routing hub | ||
| (LiteLLM-plus). See [`docs/CWL-MASTER-CONTEXT.md`](../CWL-MASTER-CONTEXT.md) | ||
| §3 and [`docs/nvidia-nim-opencode-hotfix.md`](../nvidia-nim-opencode-hotfix.md). |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.