feat: add AdditionalGrantsRevoked annotation for revoke responses#922
Open
mstanbCO wants to merge 1 commit into
Open
feat: add AdditionalGrantsRevoked annotation for revoke responses#922mstanbCO wants to merge 1 commit into
mstanbCO wants to merge 1 commit into
Conversation
Adds an annotation a connector can attach to a Revoke response when servicing a single Revoke required revoking one or more additional grants on the same principal (e.g. flipping a "has access" flag before removing a principal's last role). ConductorOne can then mark those grants revoked without dispatching redundant Revoke RPCs. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
General PR Review: feat: add AdditionalGrantsRevoked annotation for revoke responsesBlocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review SummaryThis PR adds a new Security IssuesNone found. Correctness IssuesNone found. SuggestionsNone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AdditionalGrantsRevokedannotation (proto/c1/connector/v2/annotation_additional_grants_revoked.proto) that a connector can attach to aGrantManagerServiceRevokeResponse.revoked_grant_ids— additional grants the connector had to revoke in order to service a single Revoke request (e.g. flipping a "has access" flag before removing a principal's last role).pbcode and Go helpersgrant.NewAdditionalGrantsRevoked(...)/grant.AppendAdditionalGrantsRevoked(...), mirroring the existingGrantReplacedpattern.Usage
Test plan
buf generateproduces the pb filesgo build ./...go test ./pkg/types/grant/passes (new helper tests included)Made with Cursor