Skip to content

[CXH-2015] - Return InvalidArgument instead of panicking on empty resource_id in enable_user/disable_user #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergiocorral-conductorone merged 1 commit into from
Jul 14, 2026
Merged

[CXH-2015] - Return InvalidArgument instead of panicking on empty resource_id in enable_user/disable_user #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/connector/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ func formatObjectID(resourceTypeID string, id int64) string {
}

func parseObjectID(id string) (int64, error) {
if len(id) < 2 {
return 0, fmt.Errorf("invalid resource id: %q", id)
Comment thread
luisina-santos marked this conversation as resolved.
}
return strconv.ParseInt(id[1:], 10, 64)
}

Expand Down
28 changes: 28 additions & 0 deletions pkg/connector/helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
package connector

import "testing"

func TestParseObjectID(t *testing.T) {
tests := []struct {
name string
input string
wantID int64
wantErr bool
}{
{"empty string", "", 0, true},
{"single char prefix only", "u", 0, true},
{"valid user id", "u12345", 12345, false},
{"invalid non-numeric suffix", "uabc", 0, true},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
got, err := parseObjectID(tc.input)
if (err != nil) != tc.wantErr {
t.Fatalf("parseObjectID(%q) error = %v, wantErr %v", tc.input, err, tc.wantErr)
}
if !tc.wantErr && got != tc.wantID {
t.Fatalf("parseObjectID(%q) = %d, want %d", tc.input, got, tc.wantID)
}
})
}
}
Loading