chore: remove legacy main.yaml CI workflow#27
Merged
Conversation
Duplicates ci.yaml's go-lint + go-test jobs (which already trigger on push to main) with a stale config: hardcoded go-version: 1.23.x instead of reading go.mod, checkout happening after Install Go (breaks go.sum dependency caching), and an older golangci-lint-action@v6 that resolved "latest" to a stale v1.64.8 binary built against go1.24 -- which then refuses to lint code targeting the repo's current go1.25.10, failing every push to main. Newer connectors (baton-box, baton-n8n, baton-airtable) don't carry this file at all; only ci.yaml + update-dependencies.yaml, which this repo already has. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Connector PR Review: chore: remove legacy main.yaml CI workflowBlocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review Summary Security Issues Correctness Issues Suggestions |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mateoHernandez123
approved these changes
Jul 22, 2026
Bencheng21
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/main.yaml— fully superseded byci.yaml, which already runsgo-lint+go-teston push tomain.Why
main.yamljust failed onmainafter merging #26 (https://github.com/ConductorOne/baton-jamf/actions/runs/29932437958): itsgolangci-lint-action@v6resolvedversion: latestto a stalev1.64.8binary (built against go1.24), which refuses to lint code targeting this repo's currentgo1.25.10. It also has other staleness issues: hardcodedgo-version: 1.23.xinstead of readinggo.mod, andCheckout coderunning afterInstall Go(breaks the go.sum dependency cache lookup).ci.yamlalready covers the same triggers correctly (go-version-file: go.mod, checkout-before-install,golangci-lint-action@v8) and passed cleanly on the same push. Newer connectors (baton-box, baton-n8n, baton-airtable) don't carry amain.yamlat all — justci.yaml+update-dependencies.yaml, which this repo already has.Test plan
ci.yaml's push-to-main trigger already ran and passed on the merge commit that brokemain.yamlci.yamlandmain.yaml🤖 Generated with Claude Code