Skip to content

Update baton-github dependency to v0.3.4 - #21

Merged
johnallers merged 1 commit into
mainfrom
jallers/update-baton-github-v0.3.4
May 28, 2026
Merged

Update baton-github dependency to v0.3.4#21
johnallers merged 1 commit into
mainfrom
jallers/update-baton-github-v0.3.4

Conversation

@johnallers

Copy link
Copy Markdown
Contributor

What

Updates the github.com/conductorone/baton-github dependency from v0.3.3 to v0.3.4 (latest release) and refreshes the vendor directory.

Notable upstream changes (v0.3.3 → v0.3.4)

  • Refresh GitHub App installation token on 401 (new token_refresh.go)
  • Document direct-collaborators-only option
  • Update Docker image registry from GHCR to ECR Public
  • Dependency & Go version bumps

Testing

  • make build succeeds
  • go mod tidy / go mod vendor clean; go generate produced no extra diffs

@johnallers
johnallers requested a review from a team May 27, 2026 14:34
@github-actions

Copy link
Copy Markdown
Contributor

Connector PR Review: Update baton-github dependency to v0.3.4

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Review mode: full
View review run

Review Summary

This PR bumps baton-github from v0.3.3 to v0.3.4 and vendors the new code. The main upstream change introduces a refreshableTokenSource and tokenRefreshTransport that detect 401 responses from GitHub, invalidate the cached installation token, and retry once with a freshly-issued token — addressing server-side token rotation before stated expiry. The implementation correctly handles non-rewindable request bodies, drains 401 response bodies before retry, and uses proper mutex-guarded token caching. No connector-level code, config, resource types, or scopes changed.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

@johnallers
johnallers merged commit 9660eb8 into main May 28, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants