Skip to content

chore: update baton-github to v0.3.3 - #18

Merged
johnallers merged 2 commits into
mainfrom
jallers/update-baton-github-v0.3.3
May 22, 2026
Merged

chore: update baton-github to v0.3.3#18
johnallers merged 2 commits into
mainfrom
jallers/update-baton-github-v0.3.3

Conversation

@johnallers

Copy link
Copy Markdown
Contributor

No description provided.

@johnallers
johnallers requested a review from a team May 21, 2026 21:54
Comment thread go.mod

require (
github.com/conductorone/baton-github v0.2.15
github.com/conductorone/baton-github v0.3.3

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Suggestion: baton-github v0.3.3 adds a direct-collaborators-only config option that optimizes sync for large orgs (skips per-team detail fetches, uses direct collaborator affiliation, adds org→repo expandable grants). The enterprise connector's pkg/connector/connector.go and pkg/config/config.go don't wire this field through, so enterprise users can't enable the optimization. Consider adding it in a follow-up.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

Connector PR Review: chore: update baton-github to v0.3.3

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Review mode: full
View review run

Review Summary

This PR bumps the vendored baton-github dependency from v0.2.15 to v0.3.3 and wires the new direct-collaborators-only config option through the enterprise connector. The previous review suggested adding this wiring — it is now fully addressed: the field is defined in pkg/config/config.go, included in both authentication groups (PAT and GitHub App), generated in conf.gen.go, and passed through NewLambdaConnector in pkg/connector/connector.go. Documentation in docs/connector.mdx, config_schema.json, and baton_capabilities.json are all updated to reflect the new option and the upstream SkipEntitlements annotations. No new issues found.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

- Resolve go.mod/go.sum conflicts (baton-github v0.3.3 + baton-sdk v0.9.16)
- Add direct-collaborators-only config field and wire through NewLambdaConnector
- Regenerate conf.gen.go, baton_capabilities.json, config_schema.json
- Update docs/connector.mdx with the new optional flag

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

@johnallers
johnallers merged commit c45b5d9 into main May 22, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants