Skip to content

chore: bump baton-github v0.2.12 → v0.2.13 - #13

Merged
madison-c-evans merged 1 commit into
mainfrom
cxh-1180/bump-baton-github-v0.2.13
Apr 7, 2026
Merged

chore: bump baton-github v0.2.12 → v0.2.13#13
madison-c-evans merged 1 commit into
mainfrom
cxh-1180/bump-baton-github-v0.2.13

Conversation

@madison-c-evans

Copy link
Copy Markdown
Contributor

Summary

  • Bump baton-github from v0.2.12 to v0.2.13
  • Fixes enterprise SAML emails not syncing (found during e2e validation on sandbox)

Root cause

The SDK calls ResourceSyncers() before Validate(), so the enterpriseLicensesAvailable gate was always false — enterprises were never passed to builders. v0.2.13 removes the gate and always passes enterprises through.

Test plan

  • Verified locally with go mod replace — SAML emails sync correctly
  • CI passes

🤖 Generated with Claude Code

Fixes enterprise SAML emails not syncing — the enterpriseLicensesAvailable
gate in ResourceSyncers() was always false because the SDK calls
ResourceSyncers() before Validate(). Enterprises are now always passed
through; graceful degradation happens at sync time.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@madison-c-evans
madison-c-evans requested a review from a team April 7, 2026 20:43
@linear

linear Bot commented Apr 7, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Claude finished @madison-c-evans's task in 38s —— View job


PR Review: chore: bump baton-github v0.2.12 → v0.2.13

  • Gather context
  • Review changes
  • Post review

Verdict: Looks good

This is a clean, well-scoped fix. The change removes the enterpriseLicensesAvailable gate that was always false when ResourceSyncers() ran (because the SDK calls it before Validate()), meaning enterprise SAML emails and enterprise role sync were silently disabled.

What changed (4 files, +9/−22):

  1. Removed the enterpriseLicensesAvailable field from the GitHub struct — it was dead state since ResourceSyncers() always ran before Validate() could set it to true.
  2. ResourceSyncers() now passes gh.enterprises directly to userBuilder and enterpriseRoleBuilder instead of going through the gated activeEnterprises local variable.
  3. Validate() / validateAppCredentials() still probe the consumed-licenses API but now only log a warning instead of gating functionality. The log message was updated from "will be skipped" → "may fail at sync time", which correctly reflects the new behavior.
  4. go.mod / go.sum / vendor/modules.txt — standard version bump bookkeeping.

No concerns:

  • The fix is minimal and directly addresses the root cause (ordering mismatch between ResourceSyncers and Validate).
  • The Validate probe is kept as a useful diagnostic log without gating behavior.
  • No new dependencies or API surface changes.

@madison-c-evans
madison-c-evans merged commit 9acdfaa into main Apr 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants