Skip to content

fix(config): regenerate schema with distinct suggested_value for noun/verb#46

Open
c1-squire-dev[bot] wants to merge 1 commit into
mainfrom
johnallers/connector-suggested-value-schema
Open

fix(config): regenerate schema with distinct suggested_value for noun/verb#46
c1-squire-dev[bot] wants to merge 1 commit into
mainfrom
johnallers/connector-suggested-value-schema

Conversation

@c1-squire-dev

@c1-squire-dev c1-squire-dev Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

What

Regenerates the committed connector config schema (config_schema.json) after bumping baton-sdk to the build that emits WithSuggestedValue into a distinct suggested_value schema field instead of folding it into default_value.

The noun and verb config fields now export suggestedValue (noun: ["space"]; verb: the 6-verb set administer, create, delete, export, read, restrict_content) with an empty defaultValue.

No connector source changed — pkg/config/config.go already uses WithSuggestedValue. Only the SDK dependency bump + schema regeneration.

Why (the regression)

Previously the SDK folded WithSuggestedValue into default_value in the exported schema. Because c1 injects a field's default_value into a deployed connector's resolved config, the narrow suggested set (noun=["space"], the 6 verbs) was being baked in as the effective runtime config — so deployed connectors synced fewer resources than the connector's own full runtime defaults intended.

With the fix, suggestedValue is purely for GUI pre-population and is no longer injected into resolved config. Deployed connectors fall back to the full runtime default noun/verb set, restoring the expected resource coverage.

Diff shape

  • config_schema.json: only the noun/verb defaultValuesuggestedValue flips (values unchanged).
  • baton_capabilities.json: unchanged.
  • go.mod / go.sum / vendor/: baton-sdk bump to v0.20.2-0.20260723131150-d8580bf69231.

Dependency note

This depends on baton-sdk PR #1034 (the WithSuggestedValue → separate suggested_value field change). The go.mod currently pins a pseudo-version off that PR's commit (d8580bf); once #1034 merges and a release is cut, the pin should move to the released SDK tag.

🤖 Generated with Claude Code

…/verb

Bumps baton-sdk to the build that emits WithSuggestedValue into a separate
suggested_value schema field instead of folding it into default_value.
noun/verb now export suggestedValue (GUI pre-population) with an empty
defaultValue, so c1 no longer injects the narrow set into deployed
connectors' resolved config -- they fall back to the full runtime default
noun/verb set. Fixes the "fewer resources synced" regression.

Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
@c1-squire-dev
c1-squire-dev Bot requested a review from a team July 23, 2026 13:20
@github-actions

Copy link
Copy Markdown
Contributor

Connector PR Review: fix(config): regenerate schema with distinct suggested_value for noun/verb

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base 83ee00eb3e1e.
Review mode: full
View review run

Review Summary

Scanned the full PR diff for security and correctness. The change is a config-schema regeneration: config_schema.json flips the noun/verb defaultValue to suggestedValue (values unchanged), paired with a baton-sdk bump that adds the distinct suggested_value schema field. I verified this is coherent — pkg/config/config.go already uses field.WithSuggestedValue for both fields, the vendored SDK marshals string-slice suggested values (pkg/field/marshal.go:215-220), and the runtime fallback in pkg/connector/connector.go:58-89 (filterArgs) returns the broader in-code defaultNouns/defaultVerbs when config is empty, restoring the intended resource coverage. No new source behavior; no security or correctness issues found.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

  • go.mod:47: The baton-sdk dependency is pinned to a pseudo-version (v0.20.2-0.20260723131150-d8580bf69231) built off an unmerged SDK PR. As the PR description notes, move this to the released SDK tag once that change merges and a release is cut.
Prompt for AI agents
Verify each finding against the current code and only fix it if needed.

## Suggestions

In `go.mod`:
- Around line 47: The baton-sdk require pins a pseudo-version (v0.20.2-0.20260723131150-d8580bf69231)
  derived from an unmerged upstream SDK PR. Once that SDK change merges and a tagged release is
  published, update this require to the released semver tag and run `go mod tidy` and `go mod vendor`
  so go.mod, go.sum, and vendor/ are consistent with the released version.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant