Skip to content

feat(pdok): route PDOK lookups through openconnector (closes #404)#410

Closed
rubenvdlinde wants to merge 0 commit into
developmentfrom
feature/migrate-pdok-to-openconnector
Closed

feat(pdok): route PDOK lookups through openconnector (closes #404)#410
rubenvdlinde wants to merge 0 commit into
developmentfrom
feature/migrate-pdok-to-openconnector

Conversation

@rubenvdlinde
Copy link
Copy Markdown
Contributor

Implements migrate-pdok-to-openconnector — the procest subset of shared-pdok-via-openconnector.

What

  • src/services/pdokService.js rewritten as a thin shim: all PDOK access now flows through /index.php/apps/openconnector/api/pdok/* instead of direct browser calls to api.pdok.nl.
  • All six exported function signatures preserved — src/store/modules/gis.js and src/components/map/AddressSearch.vue unchanged.
  • Degraded handling: 503 → null + message_key for display; 404 (openconnector absent) → empty result + non-blocking warning; form submission unaffected.

Dependencies

Depends on openconnector#752 (PDOK adapter PR). Functional E2E testing (PR-3) and fixture bootstrap (PR-4) deferred until openconnector is installed.

Test plan

  • Quality gate (ESLint/stylelint) green
  • Manual smoke once openconnector PDOK adapter is installed
  • Existing procest tests pass (no test file references api.pdok.nl)

Closes #404.

@github-actions
Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/procest @ c698840

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
composer ✅ 100/100
npm ✅ 419/419
PHPUnit ⏭️
Newman ⏭️
Playwright

Spec coverage: 5% (21 tests / 456 specs)


Quality workflow — 2026-05-11 21:45 UTC

Download the full PDF report from the workflow artifacts.

Copy link
Copy Markdown

@WilcoLouwerse WilcoLouwerse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Blockers

  • 🔴 suggest() returns null on 503 — breaks AddressSearch template
  • 🔴 PR-2.1 marked done but no JS unit test suite exists

🟡 Concerns

  • 🟡 Response envelope shape change is an unverified cross-repo contract
  • 🟡 lastWarning is exported but no caller reads it — 404 inline warning is dead code
  • 🟡 design.md documents free() with a start parameter that the implementation dropped

🟢 Minor

  • 🟢 design.md BASE_URL pseudocode uses hardcoded /index.php/ prefix

@rubenvdlinde
Copy link
Copy Markdown
Contributor Author

Auto-closed in error by a force-push bug in the quality-cleanup harness. Reopened as #497 with the same branch and content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants