retrofit: reverse-spec app-icon-management UUID resolution (1 REQ / 1 method)#141
Merged
rubenvdlinde merged 4 commits intoMay 25, 2026
Conversation
Drafts 1 REQ (REQ-OBICON-005) covering IconService::extractUuid (Bucket 2a from the 2026-05-24 coverage scan). Adds 1 @SPEC tag to the file docblock pointing at the ghost change's task. REQ-OBICON-005: Application UUID resolution for icon attachment lookup - codifies the @self.id -> @self.uuid -> top-level uuid fallback order and the null-return contract that load-bearing for the fallback chain in REQ-OBICON-002. Refs #137
Merges the spec delta into openspec/specs/app-icon-management/spec.md: adds retrofit_extensions frontmatter (REQ-OBICON-005) and appends the new REQ after REQ-OBICON-004. No code logic changes. Refs #137
rubenvdlinde
added
yolo
Contributor
Quality Report — ConductionNL/openbuilt @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ✅ 591/591 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-24 18:33 UTC
Download the full PDF report from the workflow artifacts.
…se-spec-openbuilt-app-icon-management-2026-05-24 # Conflicts: # .git-blame-ignore-revs
rubenvdlinde
deleted the
retrofit/reverse-spec-openbuilt-app-icon-management-2026-05-24
branch
Contributor
Quality Report — ConductionNL/openbuilt @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ✅ 591/591 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-25 08:05 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrofit — Reverse-Spec
Describes observed behaviour of 1 method under
app-icon-management(
IconService::extractUuid) as 1 new REQ.Ghost change:
retrofit-2026-05-24-app-icon-management-uuid(archived).What this PR does
retrofit_extensions: REQ-OBICON-005) on theapp-icon-managementcapability spectasks.mdwith one[x]taskIconService.phpdocblock with the new@spectagopenspec/specs/app-icon-management/spec.md)REQ
IconService::extractUuidWhat this PR does NOT do
OpenBuiltToolProvider::extractUuid(different fallback order — topvs
@self.idfirst) — separate concernReview focus
@self.idthen@self.uuidthen top-leveluuid)REQ-OBICON-002 fallback chain — scenarios codify it
Source:
openspec/coverage-report.md(Bucket 2a) generated 2026-05-24 | Cluster:app-icon-management| Refs #137