retrofit: reverse-spec openbuilt-runtime MCP surface (4 REQs / 16 methods)#140
Merged
rubenvdlinde merged 3 commits intoMay 25, 2026
Conversation
Drafts 4 REQs (REQ-OBR-MCP-001..004) covering the MCP tool-provider surface in lib/Mcp/OpenBuiltToolProvider.php (Bucket 2a from the 2026-05-24 coverage scan). Adds 4 @SPEC tags to the file docblock, each pointing at one task in the ghost change. REQ-OBR-MCP-001: MCP tool-provider contract (getAppId, getTools, invokeTool, errorResult). REQ-OBR-MCP-002: Auth-gated dispatch + arg validation (requireAuthenticatedUser, isAdmin, validateListAppsArgs, isValidSlug). REQ-OBR-MCP-003: Application resolution + uniform response mapping (resolveApplicationBySlug, mapApplication, sourceDescriptor, buildDeepLink, toArray, extractUuid). REQ-OBR-MCP-004: Draft-version manifest mutation isolation (loadVersion, saveVersionManifest). Notes the isValidSlug / SlugValidator duplication as a follow-up TODO rather than silently collapsing the two. Refs #137
Merges the spec delta into openspec/specs/openbuilt-runtime/spec.md: adds retrofit_extensions frontmatter (REQ-OBR-MCP-001..004) and appends the 4 new REQs after REQ-OBR-013. No code logic changes. Refs #137
rubenvdlinde
added
yolo
Contributor
Quality Report — ConductionNL/openbuilt @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ✅ 591/591 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-24 18:31 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
deleted the
retrofit/reverse-spec-openbuilt-openbuilt-runtime-2026-05-24
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrofit — Reverse-Spec
Describes observed behaviour of 16 methods under
openbuilt-runtime(MCP surface in
lib/Mcp/OpenBuiltToolProvider.php) as 4 new REQs.Ghost change:
retrofit-2026-05-24-openbuilt-runtime-mcp(archived).What this PR does
retrofit_extensions: REQ-OBR-MCP-001..004) on theopenbuilt-runtimecapability spectasks.mdwith one task per REQ (all[x])OpenBuiltToolProvider.phpwith 4 new@spectagspointing at the ghost change's tasks
openspec/specs/openbuilt-runtime/spec.md)REQs
getAppId,getTools,invokeTool,errorResultrequireAuthenticatedUser,isAdmin,validateListAppsArgs,isValidSlugresolveApplicationBySlug,mapApplication,sourceDescriptor,buildDeepLink,toArray,extractUuidloadVersion,saveVersionManifestWhat this PR does NOT do
isValidSlug/SlugValidatorduplication(flagged as a TODO in the Notes block of REQ-OBR-MCP-002)
Review focus
they support, not their own)
Source:
openspec/coverage-report.md(Bucket 2a) generated 2026-05-24 | Cluster:openbuilt-runtime| Refs #137