Skip to content

chore: drop OpenTalk references from connext page#33

Open
rubenvdlinde wants to merge 1 commit into
developmentfrom
chore/drop-opentalk
Open

chore: drop OpenTalk references from connext page#33
rubenvdlinde wants to merge 1 commit into
developmentfrom
chore/drop-opentalk

Conversation

@rubenvdlinde
Copy link
Copy Markdown
Collaborator

Summary

  • Drop OpenTalk from the platform overview, the /connext ExternalAppShelf, and the app-downloads.json dataset (both EN and NL connext pages)
  • Rewrite the "Why through the app store?" paragraph to keep the Nextcloud Talk pitch without the OpenTalk-on-Matrix alternative
  • We are no longer supporting OpenTalk as an integrated ExApp

Scope note

Website-only sweep. The design-system repo still ships an opentalk IntegrationIcon registry entry, brand SVG, taalgebruik glossary line, and preview pages (ExternalAppShelf / platform-overview / landing). Those will need a follow-up if/when the design-system content flows back into the live site.

Test plan

  • npm run build succeeds (Docusaurus)
  • /connext (EN) renders without the OpenTalk card in the integrated apps list
  • /connext (EN) ExternalAppShelf no longer shows OpenTalk
  • /connext (EN) "Why through the app store?" paragraph reads cleanly without the OpenTalk-on-Matrix sentence
  • /nl/connext renders without the OpenTalk card
  • data/app-downloads.json remains valid JSON

We are no longer supporting OpenTalk as an integrated ExApp, so remove
it from the platform overview, the ExternalAppShelf, and the
app-downloads dataset. Rewrites the 'Why through the app store?'
paragraph to keep the Nextcloud Talk pitch without the OpenTalk-on-
Matrix alternative.
@MWest2020
Copy link
Copy Markdown
Member

Review — chore: drop OpenTalk references from connext page

Verdict: 🟢 APPROVE — Clean sweep — alle OpenTalk-verwijzingen weg uit drie targetbestanden, JSON-validiteit bevestigd, NL/EN-pariteit klopt, CI volledig groen.

Wat goed gaat

Volledige cleanup-PR: drie bestanden raken alle OpenTalk-references in één keer. PR body bevat een nette scope-note over de design-system follow-up en een concrete test plan. NL- en EN-pariteit klopt (NL had alleen de IntegratedApps-entry, en die is geraakt). CI is volledig groen.

Findings

1. 🟢 Minor — Design-system follow-up correct uit-scope — src/pages/connext.mdx

PR description meldt expliciet dat de design-system repo nog steeds een OpenTalk IntegrationIcon, brand SVG en preview pages bevat — terecht buiten scope voor een website-only sweep, en goed gedocumenteerd voor de follow-up.

Impact: Geen, dit is alleen een notitie voor de toekomstige sync.

Suggested fix: Niets nu. Maak een tracking-issue voor de design-system kant zodra die content terug naar de live site flowt.


Geconsolideerde review via /review-pr — Thorough mode.

Copy link
Copy Markdown
Member

@MWest2020 MWest2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zie consolidated review comment voor complimenten, findings en suggested fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants