Skip to content

chore(deps): bump @conduction/docusaurus-preset to 2.1.1#29

Open
rubenvdlinde wants to merge 1 commit into
developmentfrom
chore/bump-docusaurus-preset-2.1.1
Open

chore(deps): bump @conduction/docusaurus-preset to 2.1.1#29
rubenvdlinde wants to merge 1 commit into
developmentfrom
chore/bump-docusaurus-preset-2.1.1

Conversation

@rubenvdlinde
Copy link
Copy Markdown
Collaborator

Summary

Picks up the AppMock CSS scope refactor from ConductionNL/design-system v2.1.1.

AppMock.module.css rules now require a .am parent ancestor, and AppMock.jsx wraps its own output in <div className={styles.am}> internally — so every <AppMock app="..." /> consumer in this site (the app-detail hero panels, showcase rows, deck slides) needs no source change.

The .am wrapper has display: contents so it's transparent to layout. Net visible change: zero, intended.

The fix prevents the class-name collision that bit the design-system kit's static preview pages (where .frame, .topbar, .col, .grid, .head, etc. were leaking from AppMock module into page-local CSS).

Diff scope

Only package-lock.json. Range stays ^2.0.0 in package.json; the lockfile resolves to 2.1.1. Some unrelated transitive deps re-resolved during npm update — visible in the lockfile churn but no behavior change.

Test plan

  • npm run build succeeds locally
  • App-detail pages (e.g. /apps/openregister) still render the AppMock illustrations identically
  • No regression on Showcase rows or RotatingCards that embed AppMock

Picks up the AppMock CSS scope refactor from
ConductionNL/design-system. AppMock.module.css rules now require a
'.am' parent class, and the AppMock.jsx component wraps its own
output in <div className={styles.am}> internally. <AppMock app=
'...' /> consumers (every app-detail page in this site) need no
source change -- the wrapper is added by the component.

Range stays '^2.0.0' in package.json; only package-lock.json
resolves the new exact version.
@MWest2020
Copy link
Copy Markdown
Member

Review — chore(deps): bump @conduction/docusaurus-preset to 2.1.1

Verdict: 🟢 APPROVE — Single-file lockfile bump van @conduction/docusaurus-preset 2.1.0 → 2.1.1; alle resolved URLs op registry.npmjs.org; preset is Conduction-eigen (EUPL-1.2); 16 verwijderingen vs 8 toevoegingen is legitieme deduplicatie van postcss-selector-parser 7.1.1 sub-installs; CI groen (0/4 falend).

Wat goed gaat

Heldere PR body legt uit dat de bump CSS-scope refactor uit design-system meeneemt — .am-wrapper met display: contents is transparant voor layout, dus geen consumer-changes nodig. Goed onderbouwd dat het range (^2.0.0 in package.json) ongewijzigd blijft en alleen de lockfile bewogen heeft. Test plan is concreet (npm build, app-detail pages, Showcase rows, RotatingCards). 16 verwijderde lockfile-entries zijn dedupe van postcss-selector-parser 7.1.1 — gezien de identieke integrity hashes klopt dat patroon.

Findings

1. 🟢 Minor — Lockfile audit schoon — geen typosquats, alle URLs op npmjs.org — package-lock.json

Verificatie:

  • @conduction/docusaurus-preset 2.1.1 resolved via registry.npmjs.org/@conduction/docusaurus-preset/... (correct — preset is published op Conduction's npm scope).
  • License: EUPL-1.2 (Conduction's eigen license, consistent met andere @conduction packages).
  • Geen resolved URL buiten registry.npmjs.org.
  • Net deletions zijn deduplicatie: 7 identieke postcss-selector-parser 7.1.1 entries gehoist naar één gedeelde resolution.

Impact: Lockfile is integriteits-veilig, geen supply-chain rode vlaggen.

Suggested fix: Geen actie.

2. 🟢 Minor — Test plan handmatig — geen automated check op AppMock-rendering

Test plan rust op handmatige verificatie (npm run build + visueel checken van app-detail pages). Voor een CSS-scope refactor in een component dat in showcase rows + deck slides voorkomt, is een Playwright snapshot test ideaal — maar de site heeft die nog niet.

Impact: Risico is laag omdat display: contents op de wrapper layout-neutraal is. Maar bij volgende preset-bumps blijft het handmatige-test-tax oplopen.

Suggested fix: Geen actie voor deze PR. Overweeg als follow-up één Playwright snapshot-spec voor /apps/openregister met AppMock rendering.


Geconsolideerde review via /review-pr — Thorough mode.

Copy link
Copy Markdown
Member

@MWest2020 MWest2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zie consolidated review comment voor complimenten, findings en suggested fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants