chore(deps): bump @conduction/docusaurus-preset to 2.1.1#29
chore(deps): bump @conduction/docusaurus-preset to 2.1.1#29rubenvdlinde wants to merge 1 commit into
Conversation
Picks up the AppMock CSS scope refactor from
ConductionNL/design-system. AppMock.module.css rules now require a
'.am' parent class, and the AppMock.jsx component wraps its own
output in <div className={styles.am}> internally. <AppMock app=
'...' /> consumers (every app-detail page in this site) need no
source change -- the wrapper is added by the component.
Range stays '^2.0.0' in package.json; only package-lock.json
resolves the new exact version.
Review — chore(deps): bump @conduction/docusaurus-preset to 2.1.1Verdict: 🟢 APPROVE — Single-file lockfile bump van @conduction/docusaurus-preset 2.1.0 → 2.1.1; alle resolved URLs op Wat goed gaatHeldere PR body legt uit dat de bump CSS-scope refactor uit design-system meeneemt — Findings1. 🟢 Minor — Lockfile audit schoon — geen typosquats, alle URLs op npmjs.org —
|
MWest2020
left a comment
There was a problem hiding this comment.
Zie consolidated review comment voor complimenten, findings en suggested fixes.
Summary
Picks up the AppMock CSS scope refactor from
ConductionNL/design-systemv2.1.1.AppMock.module.cssrules now require a.amparent ancestor, andAppMock.jsxwraps its own output in<div className={styles.am}>internally — so every<AppMock app="..." />consumer in this site (the app-detail hero panels, showcase rows, deck slides) needs no source change.The
.amwrapper hasdisplay: contentsso it's transparent to layout. Net visible change: zero, intended.The fix prevents the class-name collision that bit the design-system kit's static preview pages (where
.frame,.topbar,.col,.grid,.head, etc. were leaking from AppMock module into page-local CSS).Diff scope
Only
package-lock.json. Range stays^2.0.0inpackage.json; the lockfile resolves to2.1.1. Some unrelated transitive deps re-resolved duringnpm update— visible in the lockfile churn but no behavior change.Test plan
npm run buildsucceeds locally/apps/openregister) still render the AppMock illustrations identically