Skip to content

Fix knock-knock joke structure (Issue #2) - #4

Open
neomantra wants to merge 2 commits into
vibefrom
fix-knock-knock
Open

Fix knock-knock joke structure (Issue #2)#4
neomantra wants to merge 2 commits into
vibefrom
fix-knock-knock

Conversation

@neomantra

Copy link
Copy Markdown
Contributor

Summary

  • Fix knock-knock structure to include missing punchline component () per Issue knock knock joke structure is incorrect #2
  • Pattern: KK → "Who's there?" → A → "A who?" → A B. Input acts as ; appended punchline uses the same input for

Test plan

  • Build: task build
  • Run: ./injest -j knock hello world
  • Expect output lines:
    • Knock knock
    • Who's there?
    • Your data.
    • Your data, who?
    • Your data hello world
    • Your data is not a joke: hello world

💘 Generated with Crush

neomantra and others added 2 commits October 16, 2025 13:43
Adjust KnockKnockJester to follow proper pattern: KK → "Who's there?" → A → "A who?" → A B, using input as <A> and appending punchline <B>.

💘 Generated with Crush
Co-Authored-By: Crush <crush@charm.land>
…r agents

Includes task usage, golangci-lint, CodeQL, goreleaser notes, Go style conventions, testing tips, and handy run commands.

💘 Generated with Crush
Co-Authored-By: Crush <crush@charm.land>
@neomantra
neomantra changed the base branch from main to vibe October 16, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant