CMP-4248 added compliance checks#14665
CMP-4248 added compliance checks#14665vickeybrown wants to merge 1 commit intoComplianceAsCode:masterfrom
Conversation
|
Hi @vickeybrown. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
60686d8 to
419988d
Compare
419988d to
0abbd32
Compare
update # Conflicts: # shared/references/cce-redhat-avail.txt
0abbd32 to
bf565ab
Compare
|
This datastream diff is auto generated by the check Click here to see the full diffNew data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_directory_permissions_etc_sudoersd'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_etc_sudoers'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_sudo'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_etc_issue'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_etc_issue_net'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_etc_motd'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_grub2_cfg'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_user_cfg'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_efi_grub2_cfg'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_efi_user_cfg'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_system_journal'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_directory_permissions_etc_ipsecd'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_etc_ipsec_conf'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_etc_ipsec_secrets'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_directory_permissions_etc_iptables'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_directory_permissions_etc_nftables'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_etc_crypttab'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_systemmap'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_backup_etc_group'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_backup_etc_gshadow'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_backup_etc_passwd'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_backup_etc_shadow'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_etc_group'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_etc_gshadow'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_etc_passwd'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_etc_shadow'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_etc_shells'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_var_log'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_var_log_messages'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_var_log_syslog'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_dir_permissions_binary_dirs'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_dir_permissions_library_dirs'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_directory_permissions_etc_sysctld'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_library_dirs'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_directory_permissions_etc_selinux'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_etc_sestatus_conf'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_etc_chrony_keys'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_sshd_config'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_sshd_pub_key'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_audit_configuration'.
New data stream adds kubernetes remediation for rule 'xccdf_org.ssgproject.content_rule_file_permissions_audit_binaries'. |
yuumasato
left a comment
There was a problem hiding this comment.
I think this is going in the right direction
| RemainAfterExit=yes | ||
|
|
||
| [Install] | ||
| WantedBy=multi-user.target |
There was a problem hiding this comment.
Would it make sense to target basic.target, which comes up before network.target?
| filepath: | ||
| - /usr/bin/ncat | ||
| - /usr/bin/nc | ||
| filemode: '0000' |
There was a problem hiding this comment.
I wonder if 0000 is too harsh, maybe 0644 is enough?
Description:
New Rules:
scheduling binaries (at, atq, atrm, batch)
management binaries (dnf, dnf-3, yum)
netcat binaries (ncat, nc)
binary
Key Changes:
- All rules use the file_permissions template with filemode: '0000'
- Each rule includes missing_file_pass: 'true' to pass when binaries are
absent
- Platform restricted to rhcos4 only
- CCE identifiers allocated for each rule:
- Created components/nmap-ncat.yml and components/socat.yml
- Updated components/at.yml and components/dnf.yml
- All components include file_permissions template
- Added all four rules to products/rhcos4/profiles/default.profile
- Each rule includes Automatus test scenarios:
Rationale:
On RHCOS, packages in the base image cannot be removed due to the immutable OS
design. As a compensating control, this MR removes execute permissions from
security-sensitive utilities
Setting permissions to 0000 prevents these tools from being executed while
maintaining system integrity on the immutable platform
Review Hints:
Will fill this out once it's working