Conversation
KKhanhH
requested review from
Gunoshozo and
PringlesGang
and removed request for
PringlesGang
|
Lowkey kinda human vibe coded but looks like it works and chlcc doesn't have any voiced synced lines |
| TextWidth += glyph.DestRect.Width; | ||
| } | ||
| Bounds = RectF(Text[0].DestRect.X, Text[0].DestRect.Y, TextWidth, fontSize); | ||
| Bounds = Text.empty() ? RectF() |
There was a problem hiding this comment.
Accidentally snuck in a bugfix but it needs to be merged in anyway so
PringlesGang
left a comment
PringlesGang
left a comment
There was a problem hiding this comment.
During the butterfly scene, the wait icon shows on both the NVL and ADV line for MesSync, when it should only show for the ADV line
Fading also seems to be instant for sync lines when it shouldn't be
| if (!(type & 0b1000)) { | ||
| if (sync) { | ||
| dialoguePage.SyncEnabled = true; | ||
| } else { | ||
| SetFlag(SF_SYSTEMMENUDISABLE2, false); | ||
| SetFlag(SF_CHAANIME + thread->DialoguePageId, true); | ||
| dialoguePage.PlayLine(); | ||
| } | ||
|
|
||
| SetFlag(SF_SYSTEMMENUDISABLE2, false); |
There was a problem hiding this comment.
Pretty sure SetFlag(SF_SYSTEMMENUDISABLE2, false) should be hit regardless
| thread->DialoguePageId = pageId; | ||
| callback(pageId); | ||
| } else { | ||
| for (uint32_t pageId = 0; pageId < 3; pageId++) { |
There was a problem hiding this comment.
pageId < DialoguePages.size()
| ImpLogSlow(LogLevel::Warning, LogChannel::VMStub, | ||
| "STUB instruction MesSync(type: {:d})\n", type); |
| End = 2, | ||
| }; | ||
|
|
||
| bool SCRcomMesSyncMain(int pageId, SyncType type, bool useAuto) { |
There was a problem hiding this comment.
static?
Also wouldn't InstMesSyncMain fit better with the rest of our instruction names, or did you mean to not have it clash too much with the names of actual VM instructions?
| } break; | ||
| case 20: { | ||
| bool fading = false; | ||
| for (uint32_t pageId = 0; pageId < 3; pageId = pageId + 1) { |
There was a problem hiding this comment.
for (DialoguePage& page : DialoguePages)
| bool fading = false; | ||
| for (uint32_t pageId = 0; pageId < 3; pageId = pageId + 1) { | ||
| if (DialoguePages[pageId].SyncStatus != Stopped && | ||
| DialoguePages[pageId].GetState() != DialoguePage::State::Hiding) { |
There was a problem hiding this comment.
I could be wrong, but I think this should be GetState() != DialoguePage::State::Shown?
| return true; | ||
| case Shown: { | ||
| if (currentPage.AdvanceMethod == Skip) { | ||
| SetFlag(1291 + currentPage.Id, 0); |
There was a problem hiding this comment.
We don't know what this flag is?
4 participants
No description provided.