constant-text-fade-duration#441
Open
Enorovan wants to merge 2 commits into
Open
Conversation
49da004 to
4e4c6e4
Compare
PringlesGang
requested changes
Apr 8, 2026
PringlesGang
left a comment
Member
There was a problem hiding this comment.
Overall structure is quite good
47a4ced to
5a4ac9d
Compare
PringlesGang
requested changes
Apr 13, 2026
PringlesGang
left a comment
Member
There was a problem hiding this comment.
The glyph start progress should be dependent on TextSpeed, and their end progress should be an offset away from that starting progress depending on TextFadeInDuration and the currently predicted remaining duration of the line, such that it ends TextFadeInDuration seconds after the beginning progress
278573b to
b64b6e7
Compare
0ef220f to
43261a9
Compare
…press 'advance' during the cancellation of the original line
43261a9 to
8dfe744
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Makes it so glyphs start fading in based on the progress of the typewriter, but the fading in of each individual glyph takes a constant amount of time
The fading should be smooth (based on
dt), and should be resilient to changing theConfigSystem::TextSpeedandConfigSystem::SyncVoicemid-typewritingAlso fixes an issue where if you press 'advance' whilst the typewriter is cancelling (that is, you press 'advance' while it is typewriting so all glyphs start fading in immediately, and then press 'advance' again as these glyphs are still fading in), the cancellation would carry over to the next line as well, immediately cancelling it
This is a deceptively complex change, as the glyph fading progress used to be a direct calculation from the animation progress—now only the start time is; the opacity of each glyph is updated accordingly by incrementing and decrementing the opacity dynamically
The
DialoguePage's state is dependent on the typewriter's progress, so when reviewing please take careful consideration and verify whether this state machine can not break with this new implementation- Pringles