Pin workflow actions to commit SHAs and configure Dependabot - #11
Merged
Merged
Conversation
Actions referenced by a movable tag (actions/checkout@v4) run whatever the tag points to, including in the job that builds release packages. Every action is now pinned to the commit its tag resolves to today, so CI runs the same code, with the version in a trailing comment. rust-toolchain now names its toolchain explicitly so a moved pin cannot change it. dependabot.yml opens grouped weekly updates for Actions, npm and Cargo. The Commander Toolbox pin is excluded because it must match REVISION in toolbox.rs and is updated with scripts/pin-toolbox.mjs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Pins every GitHub Action to a commit SHA. Tags like
actions/checkout@v4can be moved. If one of these actions were compromised, the moved tag would run the attacker's code in the job that builds and uploads release packages. All 17uses:lines now pin the exact commit that each tag points to today, so CI runs the same code as before:actions/checkout11d5960(v4.4.0)actions/setup-node49933ea(v4.4.0)actions/upload-artifactea165f8(v4.6.2)actions/download-artifactd3f86a1(v4.3.0)dtolnay/rust-toolchain6bed076(head of itsstablebranch)rust-toolchainpicks its Rust version from the branch you reference. Its steps now passtoolchain: stableexplicitly, so a later pin update can't change the Rust version.Adds
.github/dependabot.yml. Dependabot will open grouped weekly update PRs every Monday:linutil_coreis excluded. Its revision must matchREVISIONinsrc-tauri/src/toolbox.rs, andscripts/pin-toolbox.mjsupdates the two together.Security updates were already enabled in the repository settings and are unchanged.
Updates
docs/development.mdto describe how actions are pinned and how Dependabot is configured.Validation
v4tag currently points at the pinned commit, so behaviour is unchanged.rust-toolchain, I checked that itsaction.ymlat6bed076defaults tostable.dependabot.ymlparse as YAML. No unpinneduses:remain.npm run check: passed.Review notes
🤖 Generated with Claude Code