fix(ko): point snippet imports to ko versions#1136
Merged
Conversation
57 ko pages were importing from English snippet paths (/snippets/...) instead of their translated equivalents (/snippets/ko/...), causing Korean pages to render English content blocks. All 13 target ko snippets already existed; this is a pure path fix. 92 import statements updated across 57 files. No frontmatter or translationSourceHash changes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
LGTM! Thank you! Let me check if I merged the PR that brings the changes without checking the CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the Korean docs site (docs.comfy.org/ko), some pages render parts of their content in English even though the page body is translated. The affected blocks are the shared snippets embedded in each page — e.g. the install-method accordion, "Adding Extra Model Paths", the settings-menu hint, and the tutorial update reminders.
The cause is that the Korean pages import these snippets from the English snippet path (
/snippets/...) instead of the Korean one (/snippets/ko/...). The Korean snippet translations already exist under/snippets/ko/; the pages just weren't pointing to them. (This was an omission from the initial ko bootstrap in #1109 — the translation step translated the body text but left theimport ... from "/snippets/..."path strings as-is. Thejapages already use/snippets/ja/.)Before (live site — English snippet rendered on a Korean page):
Fix
Point the snippet imports on Korean pages to their Korean versions:
This is a path-only change — no snippet content is added or translated, since every referenced
/snippets/ko/...file already exists.After (local
mint dev— Korean snippet now renders):Scope
installation3,get_started1,comfy-cli1,development1,interface12,tutorials39tutorials/update-reminder(36),partner-nodes/req-hint(26),interface/settings-menu-context(12)Notes
importpath strings changed.translationSourceHashand other frontmatter are untouched, so this won't be overwritten by the auto-translate pipeline./snippets/ko/ko/double paths, no remaining English snippet imports on ko pages, andmint devrenders the previously-English blocks in Korean.