feat(node): add changelog support to comfy node publish#469
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds end-to-end changelog support: CLI flags/env/file/stdin resolve changelog text, publish command passes it to RegistryAPI.publish_node_version, tests cover parsing/encoding/precedence/warnings, and tracking redaction now redacts token and changelog. A tiny rhyme for good measure: publish with care, and changelogs will share. ChangesPublish Changelog Support
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #469 +/- ##
==========================================
+ Coverage 83.25% 83.32% +0.06%
==========================================
Files 45 45
Lines 6804 6831 +27
==========================================
+ Hits 5665 5692 +27
Misses 1139 1139
🚀 New features to boost your workflow:
|
--changelogflag,--changelog-fileflag (-reads stdin), andCOMFY_NODE_CHANGELOGenv var tocomfy node publish; the text is sent asnode_version.changelogin the existing publish POST, populating the registry's Updates section.--changelogand--changelog-fileare mutually exclusive; either explicit flag overrides the env var (read manually viaos.environ, not typer'senvvar, so behavior is identical across typer/click versions). Files and stdin are decodedutf-8-sig(BOM-safe); input is stripped, and empty input omits the key from the request body.--changelog-file -without--tokenexits early with a clear error, since the interactive API-key prompt cannot read from stdin after the changelog consumed it.resolve_publish_changelogruns before validation so input errors exit 1 without touching the network.print(request_body)inRegistryAPI.publish_node_versionthat dumped the personal access token to stdout on every publish.tokenandchangelogtoSENSITIVE_TRACKING_KEYSso the publisher PAT and changelog text are redacted from command telemetry (key presence is still recorded).