chore: Update nodes categories (CORE-263)#14460
Conversation
alexisrolland
requested review from
Kosinkadink,
comfyanonymous,
guill,
kijai and
rattus128
as code owners
📝 WalkthroughWalkthroughThis PR reorganizes node schema metadata ( 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
comfy_extras/nodes_hunyuan.py (1)
226-244:⚠️ Potential issue | 🟠 Major | ⚡ Quick winMisspelled category path will break node organization.
Line 232 uses
"model/latent/hunyhuan video"(note "hunyhuan" instead of "hunyuan"). This differs from other Hunyuan nodes in the same file which use"model/latent/hunyuan video"and"model/conditioning/hunyuan video". The typo will fragment the node category hierarchy in the UI.Correct the spelling to
"model/latent/hunyuan video":return io.Schema( node_id="HunyuanVideo15LatentUpscaleWithModel", display_name="Hunyuan Video 15 Latent Upscale With Model", - category="model/latent/hunyhuan video", + category="model/latent/hunyuan video",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@comfy_extras/nodes_hunyuan.py` around lines 226 - 244, The category parameter in the HunyuanVideo15LatentUpscaleWithModel class's define_schema method contains a typo: "hunyhuan" should be "hunyuan". Correct the category string from "model/latent/hunyhuan video" to "model/latent/hunyuan video" to match the naming convention used by other Hunyuan nodes in the file and ensure proper node organization in the UI hierarchy.Source: Coding guidelines
comfy_extras/nodes_wan.py (1)
1253-1292:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winMove this helper into the latent hierarchy.
Wan22ImageToVideoLatentonly emits latent/noise-mask data, so keeping it undermodel/conditioning/wanputs it in the wrong UI bucket. Please move it tomodel/latent/wan(ormodel/latent) so it sits with the other latent prep nodes.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@comfy_extras/nodes_wan.py` around lines 1253 - 1292, The category field in the define_schema method of the Wan22ImageToVideoLatent class is incorrectly set to "model/conditioning/wan", but this node only outputs latent data and should be organized with other latent preparation nodes. Change the category string from "model/conditioning/wan" to "model/latent/wan" (or "model/latent" if preferred) to place it in the correct UI hierarchy alongside other latent-related nodes.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@comfy_extras/nodes_model_patch.py`:
- Around line 679-685: The NODE_DISPLAY_NAMES dictionary at the top level of the
file uses an incorrect naming convention that does not match the expected symbol
name used by the loader and import handlers elsewhere in the codebase. Rename
NODE_DISPLAY_NAMES to NODE_DISPLAY_NAME_MAPPINGS to align with the convention
used consistently across all other extras modules, which is what the server.py
loader and nodes.py import handler expect when processing this module.
In `@nodes.py`:
- Line 260: The ConditioningZeroOut class has its CATEGORY attribute set to
"model/conditioning", but this PR reorganizes conditioning transform nodes to be
under "model/conditioning/transform". Update the CATEGORY value in the
ConditioningZeroOut class from "model/conditioning" to
"model/conditioning/transform" to align with the new navigation grouping
structure implemented in this PR.
---
Outside diff comments:
In `@comfy_extras/nodes_hunyuan.py`:
- Around line 226-244: The category parameter in the
HunyuanVideo15LatentUpscaleWithModel class's define_schema method contains a
typo: "hunyhuan" should be "hunyuan". Correct the category string from
"model/latent/hunyhuan video" to "model/latent/hunyuan video" to match the
naming convention used by other Hunyuan nodes in the file and ensure proper node
organization in the UI hierarchy.
In `@comfy_extras/nodes_wan.py`:
- Around line 1253-1292: The category field in the define_schema method of the
Wan22ImageToVideoLatent class is incorrectly set to "model/conditioning/wan",
but this node only outputs latent data and should be organized with other latent
preparation nodes. Change the category string from "model/conditioning/wan" to
"model/latent/wan" (or "model/latent" if preferred) to place it in the correct
UI hierarchy alongside other latent-related nodes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ec72e218-2899-4382-ab87-c08fd529b0d5
📒 Files selected for processing (49)
comfy_extras/nodes_ace.pycomfy_extras/nodes_apg.pycomfy_extras/nodes_ar_video.pycomfy_extras/nodes_audio.pycomfy_extras/nodes_bernini.pycomfy_extras/nodes_camera_trajectory.pycomfy_extras/nodes_chroma_radiance.pycomfy_extras/nodes_clip_sdxl.pycomfy_extras/nodes_context_windows.pycomfy_extras/nodes_controlnet.pycomfy_extras/nodes_cosmos.pycomfy_extras/nodes_custom_sampler.pycomfy_extras/nodes_easycache.pycomfy_extras/nodes_edit_model.pycomfy_extras/nodes_flux.pycomfy_extras/nodes_hidream.pycomfy_extras/nodes_hidream_o1.pycomfy_extras/nodes_hunyuan.pycomfy_extras/nodes_hunyuan3d.pycomfy_extras/nodes_ideogram4.pycomfy_extras/nodes_kandinsky5.pycomfy_extras/nodes_latent.pycomfy_extras/nodes_lt.pycomfy_extras/nodes_lt_audio.pycomfy_extras/nodes_lt_upsampler.pycomfy_extras/nodes_lumina2.pycomfy_extras/nodes_mask.pycomfy_extras/nodes_mochi.pycomfy_extras/nodes_model_advanced.pycomfy_extras/nodes_model_merging.pycomfy_extras/nodes_model_merging_model_specific.pycomfy_extras/nodes_model_patch.pycomfy_extras/nodes_pid.pycomfy_extras/nodes_pixart.pycomfy_extras/nodes_post_processing.pycomfy_extras/nodes_qwen.pycomfy_extras/nodes_scail.pycomfy_extras/nodes_sd3.pycomfy_extras/nodes_sdupscale.pycomfy_extras/nodes_stable3d.pycomfy_extras/nodes_stable_cascade.pycomfy_extras/nodes_train.pycomfy_extras/nodes_video_model.pycomfy_extras/nodes_void.pycomfy_extras/nodes_wan.pycomfy_extras/nodes_wandancer.pycomfy_extras/nodes_wanmove.pycomfy_extras/nodes_zimage.pynodes.py
…rg/ComfyUI into alexis/update_categories
alexisrolland
changed the title
1 participant
Massive update of nodes categories to make navigation more intuitive in the context menu:
model/conditioningmodel/latentmodel/loadermodel/mergingmodel/patchadvanced/[..]nodes dispatched into categories aboveAlso updated a couple of nodes titles and description for consistency.