Skip to content

Add Stylebook and SceneWeaver to custom node index - #3403

Merged
ltdrdata merged 1 commit into
Comfy-Org:mainfrom
EnragedAntelope:register-stylebook-sceneweaver
Oct 27, 2026
Merged

ltdrdata merged 1 commit into
Comfy-Org:mainfrom
EnragedAntelope:register-stylebook-sceneweaver

Conversation

@EnragedAntelope

Copy link
Copy Markdown
Contributor

Summary

  • Register Stylebook and SceneWeaver in custom-node-list.json.
  • Use the same repository URLs as their existing Comfy Registry records.
  • Leave generated databases and all Manager code unchanged.

Repositories:

Both packs already appear through Comfy Registry, but have no entries in the
Manager catalog. Their rows therefore use Registry page URLs as reference,
and populate_github_stats cannot match those URLs to GitHub statistics.
The normal scanner also does not discover their repository URLs from this
catalog. Both stars and Last Update consequently show N/A.

These entries put the packs on the existing catalog-backed Registry merge
path. That path retains the GitHub reference and emits the update-state field
used by the UI. The general Registry-only update-state defect is already
tracked in #3220 and addressed by the existing #3261; this PR does not duplicate
that code change.

Please allow the normal database generation to populate github-stats.json;
no generated statistics are included here.

Validation

  • Parsed the complete modified JSON; confirmed exactly two additions, matching
    canonical repository URLs, no duplicate target entries, and no modifications
    to existing entries.
  • Ran the actual scanner.get_git_urls_from_json function against this file;
    both repository URLs were discovered.
  • Exercised the actual Manager catalog loader, Registry merge, and GitHub stats
    lookup in an isolated harness using the local catalog and read-only live
    Registry snapshots. Installation-state scenarios used synthetic inventory;
    the live API separately confirmed that both installed packs were nightly.
    Filesystem reload was disabled; production merge/lookup functions were not
    reimplemented.
  • Reproduced the current last_update=-1 and missing update-state rows using
    the original catalog. With these entries and fresh GitHub statistics modeling
    the next scanner refresh, both dates and stars resolved.
  • Checked nightly, older stable, current stable, and not-installed states;
    older stable versions emitted update-state=true, while current stable
    versions did not. Verified the adjacent Identity Forge row was unchanged.
  • Ran
    python -m pytest tests/test_pack_column_escaping.py tests/test_update_result_rendering.py -q:
    16 passed, 2 skipped, 16 subtests passed. The optional Playwright scenarios
    were skipped; metadata-column tests ran.
  • git diff --check passed.

The README's exact Use local DB dialog check was not performed: no connected
browser automation session was available. The real local-mode loader and merge
were checked through the isolated harness instead. No queue operations, jobs,
installs, updates, or restarts were performed on the running ComfyUI instance.
The checkout's full Ruff check could not run because Ruff is not installed in
the available Python environment; this change contains no Python edits.

Registry security flags on the latest releases are separate from this catalog
registration. This PR does not clear flags or bypass installation policy.

- Register Stylebook and SceneWeaver with canonical repository URLs
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: fc3a5f34-cd9d-4bb4-8ad5-bf67b00a5e23
📥 Commits

Reviewing files that changed from the base of the PR and between a74929c and 580052d.

📒 Files selected for processing: 1
  • custom-node-list.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The custom node list adds Stylebook and SceneWeaver. Each entry includes its author, title, GitHub reference, git-clone install type, and feature description.

Changes: Node catalog additions

Layer / File(s) Summary
Add node-pack catalog entries
custom-node-list.json
Adds Stylebook and SceneWeaver entries with their authors, titles, GitHub references, install types, and descriptions.

Suggested reviewers: ltdrdata

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 58005

The two additions follow the existing catalog paths for discovery and Registry metadata. No concrete merge-blocking risk was identified.

Pre-merge checks: Passed 2
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
✨ Simplify code
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

⚠️ This pull request has been flagged as potential spam (promotional) by CodeRabbit slop detection and should be reviewed carefully.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from ltdrdata October 22, 2026 03:44
@EnragedAntelope

Copy link
Copy Markdown
Contributor Author

For context on the automated promotional-spam warning: this is a functional
Manager catalog registration, not a request to advertise new packs. Both packs
are already published in Comfy Registry.

On the existing catalog, the live API returned a Registry-page reference,
stars: -1, and last_update: -1 for both packs. The scanner discovers its
GitHub targets from custom-node-list.json, and the stats lookup matches
reference against those GitHub URLs. These two entries supply the missing
catalog records and preserve the existing Registry identities.

This also uses the existing catalog-backed path that supplies update-state.
The general Registry-only omission is already tracked by #3220 and PR #3261;
this PR does not duplicate that fix.

The change is limited to the two entries. Generated statistics still require
the normal database refresh after merge. The validation and browser-check
limitations are documented in the PR description. No code changes were
requested by the automated review, and all current checks passed.

@ltdrdata
ltdrdata merged commit a494918 into Comfy-Org:main Oct 27, 2026
3 checks passed
@EnragedAntelope
EnragedAntelope deleted the register-stylebook-sceneweaver branch October 27, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants