Repository navigation
Add Stylebook and SceneWeaver to custom node index - #3403
Conversation
- Register Stylebook and SceneWeaver with canonical repository URLs
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
|
For context on the automated promotional-spam warning: this is a functional On the existing catalog, the live API returned a Registry-page This also uses the existing catalog-backed path that supplies The change is limited to the two entries. Generated statistics still require |
Summary
custom-node-list.json.Repositories:
Both packs already appear through Comfy Registry, but have no entries in the
Manager catalog. Their rows therefore use Registry page URLs as
reference,and
populate_github_statscannot match those URLs to GitHub statistics.The normal scanner also does not discover their repository URLs from this
catalog. Both stars and Last Update consequently show
N/A.These entries put the packs on the existing catalog-backed Registry merge
path. That path retains the GitHub reference and emits the
update-statefieldused by the UI. The general Registry-only update-state defect is already
tracked in #3220 and addressed by the existing #3261; this PR does not duplicate
that code change.
Please allow the normal database generation to populate
github-stats.json;no generated statistics are included here.
Validation
canonical repository URLs, no duplicate target entries, and no modifications
to existing entries.
scanner.get_git_urls_from_jsonfunction against this file;both repository URLs were discovered.
lookup in an isolated harness using the local catalog and read-only live
Registry snapshots. Installation-state scenarios used synthetic inventory;
the live API separately confirmed that both installed packs were nightly.
Filesystem reload was disabled; production merge/lookup functions were not
reimplemented.
last_update=-1and missingupdate-staterows usingthe original catalog. With these entries and fresh GitHub statistics modeling
the next scanner refresh, both dates and stars resolved.
older stable versions emitted
update-state=true, while current stableversions did not. Verified the adjacent Identity Forge row was unchanged.
python -m pytest tests/test_pack_column_escaping.py tests/test_update_result_rendering.py -q:16 passed, 2 skipped, 16 subtests passed. The optional Playwright scenarios
were skipped; metadata-column tests ran.
git diff --checkpassed.The README's exact
Use local DBdialog check was not performed: no connectedbrowser automation session was available. The real local-mode loader and merge
were checked through the isolated harness instead. No queue operations, jobs,
installs, updates, or restarts were performed on the running ComfyUI instance.
The checkout's full Ruff check could not run because Ruff is not installed in
the available Python environment; this change contains no Python edits.
Registry security flags on the latest releases are separate from this catalog
registration. This PR does not clear flags or bypass installation policy.