Skip to content

Add NH-Nodes - #3393

Open
jetthuangai wants to merge 1 commit into
Comfy-Org:mainfrom
jetthuangai:add-nh-nodes
Open

jetthuangai wants to merge 1 commit into
Comfy-Org:mainfrom
jetthuangai:add-nh-nodes

Conversation

@jetthuangai

Copy link
Copy Markdown
Contributor

Adds NH-Nodes to custom-node-list.json.

NH-Nodes is a pack of 76 nodes for photo and production work:

MIT for the pack's own code. Some nodes use third-party models with their own terms, listed in THIRD_PARTY_NOTICES.md. Tests and docs (EN/VI) are included.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f47462a7-e453-413f-bded-aa865b160de7
📥 Commits

Reviewing files that changed from the base of the PR and between b0b8bbe and 7938df9.

📒 Files selected for processing: 1
  • custom-node-list.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The custom node catalog adds NH-Nodes, including its author, GitHub repository, installation URL, install type, and a description of its 76 nodes.

Changes: Node catalog

Layer / File(s) Summary
Add NH-Nodes catalog entry
custom-node-list.json
Adds a git-clone catalog record for NH-Nodes with its author, GitHub repository, installation URL, and description of its 76 nodes.

Suggested reviewers: ltdrdata

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 7938d

This change adds a catalog entry for NH-Nodes using the install type the scanner already supports. No concrete merge-blocking risk was found.

Security architecture risk: 🔵 Low · up to 7938d

This adds one external repository to the existing catalog-processing workflow. No introduced security defect was established, but the scanner’s permissions, isolation, and catalog authorization controls remain unverified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The newly selected repository can influence its local checkout, recursive dependency retrieval, and generated node-map data. Maximum exposure beyond that scanner workspace cannot be established without its execution permissions, isolation, and downstream-consumer context.

Trust Boundaries and Controls

  • observed — The catalog-to-network boundary is established: a selected files URL reaches recursive Git operations. Who may authorize catalog changes, how catalog provenance is enforced, and which runtime identity performs those operations remain proof gaps rather than verified control failures.

Resilience and Maintainability Implications

  • observed — The existing lifecycle keys checkouts by repository basename, pulls an existing path without comparing its origin to the selected URL, and records Git exceptions without a success gate for subsequent scanning. Workers finish before scanning begins, but stale or partially updated contents can remain eligible for extraction. These recovery and ownership limitations predate this addition; no new NH-Nodes basename collision was identified.
Pre-merge checks: Passed 2
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
✨ Simplify code
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from ltdrdata October 19, 2026 02:56
@ltdrdata

Copy link
Copy Markdown
Member

Thanks for the submission.

  1. Save Image Path — folder_path is used as given when absolute and joined unchecked otherwise (nodes/image/save_image_path.py:14-22), so a workflow can write images anywhere the ComfyUI process can (:125-173). Please keep the save folder inside ComfyUI's output directory, or take extra save roots only from a setting on disk.

  2. UI language — the Qwen preset note shown by Smart Resolution Picker is Vietnamese (core/resolution_data.py:46).

I'll re-evaluate once this is fixed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants