Skip to content

Adapt Akka Future to Java 8 CompletableFuture - #133

Open
HaloFour wants to merge 1 commit into
Comcast:masterfrom
HaloFour:java8_completableFuture
Open

Adapt Akka Future to Java 8 CompletableFuture#133
HaloFour wants to merge 1 commit into
Comcast:masterfrom
HaloFour:java8_completableFuture

Conversation

@HaloFour

Copy link
Copy Markdown
Collaborator

This is a much simpler approach. I've updated the AkkaFutureAdapter class to instead convert the Akka Future[T] to a Java 8 CompletableFuture[T].

I've kept the Sirius interface the same as in that it continues to return Future[T] which would eliminate the potential for breaking a consumer which implements that interface directly, but that does put additional onus on the consumer to determine if the returned Future[T] is a CompletableFuture[T] or not.

@CLAassistant

CLAassistant commented Dec 20, 2017

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants