Patch Anomalies Expected#4637
Open
DarkByteZero wants to merge 6 commits into
Open
Conversation
- DamageDefs: Convert silent-fail PatchOperationReplace -> Add for AENitrogen / AENitrogenPlayer armorCategory (source defs do not declare the element). AEFreezing keeps Replace (source declares Blunt locally). - Races_Entities: Convert ArmorRating_Sharp/Blunt (and Heat for BrokenStatue) Add -> per-stat Replace for all 6 entities (SnowMan, SnowGolem, SnowSpider, IceMantis, IceMan, BrokenStatue). Source defs already declare these stats, so Add was creating duplicates and producing warnings. - Races_Entities: Remove canParry/maxParry from AE_SnowGolem RacePropertiesExtensionCE. CE convention restricts parry to Humanoid bipeds with weapon-arms; SnowGolem is Quadruped. - Weapons_Ranged: Petrification Gun recoilAmount 2.80 -> 3 (CE convention for burst weapons). - All 5 patch files wrapped in PatchOperationFindMod -> PatchOperationSequence to gate execution on Anomalies Expected being loaded.
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-28139309910.zip |
github-actions
Bot
added
the
Download in Comments
AE_Bullet_Shell_SnowBlockAbility inherits Gun_AESnowBlock_Thrown but its own projectile element needs the CE class attribute set explicitly, otherwise the inherited armorPenetrationBlunt and dangerFactor fields fail XML parse. Balance pass anchored against centipede (Sharp 20 Blunt 45 Durability 3660) and scyther (4 / 6) instead of Metalhorror (HP 0.6 parasite). BrokenStatue moves into centipede tier, SnowGolem above pikeman, IceMantis to scyther-light. SnowSpider drops slightly to match its CP 40 swarmer role.
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-28140580723.zip |
Source def has no <comps> element. The Add op silently failed and dropped the ArmorDurability comp. Use PatchOperationConditional to create <comps /> on nomatch so the subsequent Add resolves.
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-28140941061.zip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additions
Changes
none
References
none
Reasoning
Alternatives
Testing
Check tests you have performed: