v0.17.0 — the QA engine, plus mid-drag docking with shake-to-disconnect

[Coldbari]

Two commits from a shared working tree, kept separate because they are unrelated changes by different sessions.

efcccef — v0.17.0, the QA engine

Validation becomes a rule engine instead of two lists split by an implicit flag.

• Severity is real. It used to be encoded as the absence of a field (severity?: 'suggestion', where undefined meant error), so there was no middle. 21 rules now declare critical / warning / information and a discipline, and the report groups by severity because that is how an engineer triages.
• Accept a finding, with a reason. Not every finding is a mistake. The reason is recorded and stays visible in its own section — a hidden acceptance rots. Because findings are keyed by rule + engineering identity and never by node id, an acceptance survives deleting and redrawing the symbol.
• Fixes are data, not callbacks. A rule returns a FixSpec, so a repair can be named, previewed with its blast radius, and replayed in a test. applyFix reports whether it landed instead of failing silently.
• One index per document. runChecks alone used to build four maps; the advisor rebuilt a neighbour list per node per rule.

Three bugs it found

• P-101 on a pump was reported as an invalid ISA tag. invalid-letters ran the ISA-5.1 instrument letter tables over equipment. Found by running the new rules against this project's own bundled templates — the false positive existed in the old engine too.
• The same finding was emitted twice when two symbols wore one tag, so accepting one silently accepted both.
• qaFor's cache never hit — doc.qa?.ignored ?? {} allocated a fresh object per call, re-running all 21 rules on every render.

Calibrated against real drawings

Run over the five bundled examples, the rule set initially reported criticals on three of them and 11–13 identical warnings. That teaches people to ignore the report. So no-relief and no-fail-position are warnings rather than blockers by default (a company standard promotes them in v0.18), and required-field-empty only fires on a record someone has started. All five bundled drawings now report zero criticals.

Retires validate/checks.ts, suggest.ts, issues.ts and the two panels that read them; coverage moved to rule tests. locateCell moves to canvas/locate.ts.

659ff7d — mid-drag docking with shake-to-disconnect

Authored by a concurrent session in the same checkout. Docking no longer waits for the mouse button: the line is drawn the moment two connection points meet and stretches as the drag continues. Symbols stand off 24px along the way the port faces (coinciding points read as nothing having happened); magnets only join ports that face each other; shaking the symbol mid-drag cuts the line that drag made. One undo step. Also fixes a pointer-event ordering bug where pointerup on window lands before JointJS's compatibility mouseup.

Verification

• npm run build — clean
• npm test — 746 passing
• npx playwright test --workers=1 — 68 passing

Run serially on purpose: the e2e suite flaps against the shared dev server when multiple sessions are editing, because HMR reloads kill tests mid-run.

tsc -b initially reported clean because the check was piped through head, which masked its exit code; an isolated worktree at the commit surfaced two real TS6133 errors, since fixed.

🤖 Generated with Claude Code