test(support): stop the route tests from opening a real database connection - #221
Merged
Merged
Conversation
…ection withApiRequestContext binds the session's tenant DB around every handler, so the support route tests connected to MongoDB for real. That passed locally, where an instance happens to be running, and timed out after five seconds on every case in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CI failure on
mainintroduced by #220.withApiRequestContextbinds the session's tenant DB around every handler, sosrc/__tests__/api/support.test.tsopened a real MongoDB connection on eachrequest. That passed locally, where an instance happens to be running, and
timed out after five seconds on all ten cases in CI:
The test now mocks
@/lib/databasewith arunWithTenantthat simply invokesthe callback, the same shape the other Fastify plugin tests use. That keeps the
tenant-binding branch exercised instead of skipping it.
10 tests, 5006ms → 55ms, no database required.