-
Notifications
You must be signed in to change notification settings - Fork 0
fix(registry): rewrite schema $id to the resolvable Pages registry URL #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,7 @@ export async function createValidator(directory = schemaRoot) { | |
| } | ||
|
|
||
| export function schemaId(version, name) { | ||
| return `${canonicalSchemaBase}/${version}/${name}.schema.json`; | ||
| return `${pagesRegistryBase}/${version}/${name}.schema.json`; | ||
| } | ||
|
Comment on lines
45
to
47
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
After changing the authoritative schema IDs to the Pages registry, the executable artifact-manifest fixtures still advertise Useful? React with 👍 / 👎. |
||
|
|
||
| export function schemaIdForExample(examplePath) { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This documents the
$idrewrite as breaking, but the commit applies it in-place to the existing v0.1/v1.0/v1.1 schema lines while their recordschemaVersionconstants remain unchanged. Any patch or minor release from these directories will make consumers keyed to the already-published IDs fail to resolve schemas even though the contract version did not move to a new major, which violates the repository versioning rule for published schemas. Keep aliases/the old IDs for existing lines, or introduce this Pages-ID migration in a new major schema line.Useful? React with 👍 / 👎.