Listing loops, insights or the review queue adopts hand deletions and says how many it forgot - #20
Merged
Merged
Conversation
… by hand and says how many it forgot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #240 and #241 for the CLI.
Deleting a line from loops.md, dream-insights.md or memories/pending.md was ignored by listing until the next write, and the write that did adopt it said nothing.
logos loop,logos dream review/decideandlogos reviewnow reconcile first and printadopted your edit to <file>: N … forgottenwhen anything changed.Not covered: the MCP paths (
awaitingReviewcount, a quarantined remember) still adopt silently.Tests:
cmd/logos/hand_edits_test.go, all four fail on main.