Repository quality: CI, staticcheck, shared nudges, a cache registry test, split god files, thin-package tests, and hand edits that hold - #16
Merged
Conversation
…s what it meant to, and the archive destination check reads without a loop that always breaks
…check, tests and the chaos tier
…age, so a nudge or a wording fix reaches both
…ified is kept, and the receipt asks for the command that showed it
…d row for row after deleting the index, or declared a cache with the reason
…y the protocol and the dispatch
… live in their own file, so setup.go holds the flow
…nd indexing each in a file of their own
…les, so health.go holds the report and the index checks
…off, a configured runtime, errors, schemas and both streaming paths
…edding, vector ranking, fusion with a lexical-only hit, and graph expansion
… is added or closed, without waiting for an index
…the next one is queued or reviewed, without waiting for an index
…xt one arrives or is reviewed, without waiting for an index
…from the next change logos makes there, not only from the next index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eight of the nine quality items. The ninth, removing the 0.4 fallbacks, is already on main as 77256c0.
logos indexran before the next change. Otherwise the next write put the line back. Each store now adopts hand edits under its lock before rewriting the file, and skips that work when a sha256 stamp shows the file is still the one it wrote. Closing a loop, ruling on an insight, or accepting or rejecting a proposal whose line was just deleted now errors and names the file, instead of reporting success on nothing.Verified:
go build ./... && go test ./... && go vet ./... && gofmt -l .,go test -count=1 -tags chaos ./chaos/..., staticcheck v0.8.1. A scratch-vault run ofloop addafter a hand deletion kept the line gone, andloop doneon the deleted id exited 1 with an error.Known follow-ups, not in this PR: listing ignores a hand deletion until the next write or index; adopting an edit during a write doesn't say what it removed; memory's file stamps survive rebinding a store to another vault; and a row whose vault write failed is deleted by the next full adopt.