fix: unblock Dependabot by aligning phpcs coding-standards deps - #1107
Merged
Conversation
Dependabot could not resolve any update for this repo (no Dependabot PRs since Jan 2025) because the locked codeinwp/phpcs-ruleset (dev-main) required dealerdirect/phpcodesniffer-composer-installer ^0.7.0 while the lock resolved installer to 1.2.1 — an unresolvable conflict, so every dependency (including codeinwp/themeisle-sdk) was reported update_not_possible. - Bump installer constraint ^0.7.2 -> ^1.0 to match phpcs-ruleset's current requirement - Refresh the lock (phpcs-ruleset dev-main, squizlabs/php_codesniffer, phpcs-variable-analysis, phpcompatibility) so the tree resolves again - Bring codeinwp/themeisle-sdk up to 3.3.58 while unblocked Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
The refreshed coding-standards toolchain surfaced two pre-existing docblock violations in class-rop-scheduler-model.php (missing @PARAM type and spacing). Fixed so PHP Lint passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…eline The docblock now uses a typed array (mixed[]) so it satisfies both the updated PHPCS (MissingParamType) and PHPStan (missingType.iterableValue). Removed the now-obsolete phpstan-baseline.neon entry that ignored the old "parameter $new_events with no type specified" error, which no longer occurs and would otherwise be reported as an unmatched ignore. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ningful Using mixed[] made PHPStan treat the parameter as always-array, flagging the is_array() guard as always-true. `mixed` satisfies PHPCS's param-type requirement while preserving the runtime guard and avoiding the iterable-value rule. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 9.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot has produced no PRs for any dependency since Jan 2025 on this repo. The Dependabot job log shows every dependency (including
themeisle-sdk) reportedupdate_not_possiblewith:The locked
phpcs-ruleset(an old dev-main commit) required installer^0.7.0, contradicting the rest of the tree — so Composer could not resolve any update, blocking the whole repo.What
composer.json:dealerdirect/phpcodesniffer-composer-installer^0.7.2→^1.0(matches currentphpcs-ruleset).composer.lock:phpcs-rulesetdev-main → latest,squizlabs/php_codesniffer,phpcs-variable-analysis,phpcompatibilityrefreshed so the tree resolves.codeinwp/themeisle-sdk3.3.54 → 3.3.58 while unblocked.wp-coding-standards/wpcsis intentionally left at 2.x (its 3.x bump is capped upstream bywptrt/wpthemereviewand is a separate, org-wide toolchain task). After this merges, Dependabot can resolve and resume opening update PRs.