Enforced maximum post age when sharing queued posts - #1103
Merged
Conversation
pirate-bot
added
the
pr-checklist-complete
Contributor
There was a problem hiding this comment.
🟡 Not ready to approve
The added buffer update can overwrite newer queue-removal state and permit posts to be queued again.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Revalidates queued posts at share time to prevent stale or unpublished content from being shared.
Changes:
- Adds post-age and eligibility checks.
- Skips and logs ineligible queued posts.
- Adds PHPUnit coverage for aged queued posts.
File summaries
| File | Description |
|---|---|
includes/admin/class-rop-admin.php |
Revalidates posts before sharing. |
includes/admin/models/class-rop-posts-selector-model.php |
Adds reusable eligibility checks. |
includes/class-rop-i18n.php |
Adds the skip log message. |
tests/test-queue.php |
Tests eligibility and queue behavior. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Soare-Robert-Daniel
approved these changes
Aug 3, 2026
6 tasks
selul
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revalidate queued posts before sharing them to ensure they are still eligible at the time of sharing, preventing posts that became ineligible after being queued from being shared.
Check before Pull Request is ready:
Closes #1101