Admin password draws from the full mixed alphabet - #42
Merged
Conversation
Maps the raw HMAC digest onto letters/digits/symbols instead of showing the digest's hex form — still fully deterministic from seed + auth salt, so redisplay and the wp_check_password sync guard are unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merged #40's page test meets #42's alphabet: the admin password can now contain '&', which the page escapes via esc_html, so the raw-substring assertion failed whenever a run's random seed produced one (only some CI legs hit it). Assert esc_html() of both credentials — the exact form the row renders. Verified stable across repeated seeds. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The derived admin password displayed the HMAC digest's hex form — 24 chars of
[a-f0-9], which looks weak and can trip hosts that enforce mixed character classes. It now maps the raw digest bytes onto the full alphabet (upper/lower/digits/!@#$%^&*()-_=+), one byte per character.Still fully deterministic from seed + auth salt: redisplay, the
wp_check_passwordsync guard, and the agent token derivation are all unchanged. ~6.2 bits per character × 24 ≈ way past the effective HMAC bound either way — this is presentation and host-policy compatibility, not an entropy change.Tests assert the alphabet and that the password isn't the bare hex digest. 21/21 green.
🤖 Generated with Claude Code