Release

assets/apps/components/src/Common/SingleSizingInput.js

@@ -1,4 +1,5 @@
 import PropTypes from 'prop-types';
+import { useState } from '@wordpress/element';
 
 const SingleSizingInput = ({
 	type,
@@ -10,20 +11,25 @@ const SingleSizingInput = ({
 	label,
 	disabled,
 }) => {
+	// Partial input like "-" reads as empty; rendering 0 would erase it.
+	const [isEmptyInput, setIsEmptyInput] = useState(false);
+
 	return (
 		<div className="nv-sizing-item">
 			<input
 				style={disabled ? { backgroundColor: '#dddddd' } : {}}
 				disabled={disabled}
 				type="number"
 				className={type ? type + '-input' : ''}
-				value={value}
+				value={isEmptyInput ? '' : value}
 				min={min}
 				max={max}
 				step={step}
-				onChange={(e) =>
-					onChange(type, e.target.value === '' ? 0 : e.target.value)
-				}
+				onChange={(e) => {
+					setIsEmptyInput(e.target.value === '');
+					onChange(type, e.target.value === '' ? 0 : e.target.value);
+				}}
+				onBlur={() => setIsEmptyInput(false)}
 			/>
 			{label && (
 				<label className="label" htmlFor={type + '-input'}>

assets/apps/components/src/Controls/Sizing.js

@@ -6,6 +6,13 @@ import { __ } from '@wordpress/i18n';
 import { mapValues } from 'lodash';
 import { Button, Tooltip } from '@wordpress/components';
 
+/**
+ * @param {string|number|null|undefined} value Control value or default.
+ * @return {boolean} Whether the value is unset.
+ */
+const isEmptyValue = (value) =>
+	value === '' || value === null || value === undefined;
+
 const SizingControl = ({
 	noLinking,
 	options,
@@ -61,8 +68,11 @@ const SizingControl = ({
 
 	const hasSetValues = () => {
 		if (typeof defaults !== 'object') {
-			// eslint-disable-next-line eqeqeq
-			return parseFloat(defaults) != parseFloat(options[0].value);
+			const current = options[0].value;
+			if (isEmptyValue(defaults) || isEmptyValue(current)) {
+				return isEmptyValue(defaults) !== isEmptyValue(current);
+			}
+			return parseFloat(defaults) !== parseFloat(current);
 		}
 		return (
 			options.filter(

assets/apps/customizer-controls/src/builder/scss/_customizer-adjustments.scss

@@ -12,7 +12,14 @@ ul[id^="sub-accordion-panel-hfg_"] {
   }
 
   #accordion-section-neve_header_presets,
-  #accordion-section-neve_footer_copyright_section {
+  #accordion-section-neve_footer_copyright_section,
+  #accordion-section-neve_global_footer_settings {
 	  margin-top: 20px;
   }
+
+  // Only some sites get the copyright section; when it is there, the two form one group.
+  #accordion-section-neve_footer_copyright_section
+  + #accordion-section-neve_global_footer_settings {
+	  margin-top: 0;
+  }
 }

assets/apps/customizer-controls/src/controls.js

@@ -316,9 +316,8 @@ const bindDataAttrQuickLinks = () => {
 };
 const checkHasElementorTemplates = () => {
 	if (NeveReactCustomize.elementor.hasElementorShopTemplate) {
-		window.wp.customize
-			.section('woocommerce_product_catalog')
-			.notifications.add(
+		window.wp.customize.section('woocommerce_product_catalog', (section) =>
+			section.notifications.add(
 				new window.wp.customize.Notification(
 					'neve-custom-elementor-shop-template',
 					{
@@ -329,13 +328,13 @@ const checkHasElementorTemplates = () => {
 						),
 					}
 				)
-			);
+			)
+		);
 	}
 
 	if (NeveReactCustomize.elementor.hasElementorProductTemplate) {
-		window.wp.customize
-			.section('neve_single_product_layout')
-			.notifications.add(
+		window.wp.customize.section('neve_single_product_layout', (section) =>
+			section.notifications.add(
 				new window.wp.customize.Notification(
 					'neve-custom-elementor-product-template',
 					{
@@ -346,7 +345,8 @@ const checkHasElementorTemplates = () => {
 						),
 					}
 				)
-			);
+			)
+		);
 	}
 };
 

assets/apps/customizer-controls/src/scss/_general.scss

@@ -75,7 +75,8 @@
 
 
 #sub-accordion-panel-hfg_header #accordion-section-neve_header_presets,
-#sub-accordion-panel-hfg_footer #accordion-section-neve_footer_copyright_section {
+#sub-accordion-panel-hfg_footer #accordion-section-neve_footer_copyright_section,
+#sub-accordion-panel-hfg_footer #accordion-section-neve_global_footer_settings {
   display: list-item !important;
 }
 

assets/apps/customizer-controls/src/typeface/Typeface.js

@@ -260,11 +260,7 @@ const Typeface = (props) => {
 				label={__('Letter Spacing', 'neve')}
 				step={0.1}
 				default={defaultLS[currentDevice]}
-				value={
-					letterSpacing && letterSpacing[currentDevice]
-						? letterSpacing[currentDevice]
-						: ''
-				}
+				value={letterSpacing[currentDevice] ?? ''}
 				max={20}
 				min={-5}
 				units={['px']}

assets/apps/dashboard/src/utils/common.js

@@ -83,7 +83,8 @@ const getTabHash = () => {
 
 	hash = hash.substring(1);
 
-	if (!tabs[hash]?.render && !tabs[hash]?.url) {
+	// Tabs with only a `url` are links (e.g. Starter Sites once the plugin is active), not content.
+	if (!tabs[hash]?.render) {
 		return null;
 	}
 

assets/scss/components/compat/woocommerce/_cart.scss

@@ -31,6 +31,7 @@
 
 .woocommerce-cart table.cart td.actions .coupon {
 	display: flex;
+	flex-wrap: wrap;
 }
 
 //</editor-fold>

assets/scss/components/editor/_typography.scss

@@ -1,8 +1,10 @@
 @import "../main/global-colors";
 @import "../main/variables";
 
+// In the iframed editor the wrapper is the body itself.
 main,
 body &,
+&:is(body),
 body & p {
 	color: var(--nv-text-color);
 	font-size: var(--bodyfontsize);
@@ -52,21 +54,30 @@ h5,
 h6 {
 	margin-bottom: $spacing-lg;
 	margin-top: 0;
-
-	&.wp-block,
-	& {
-		font-family: var(--headingsfontfamily, var(--bodyfontfamily));
-		color: var(--headingcolor, inherit);
-	}
 }
 
 $headings: [h1,h2,h3,h4,h5,h6];
 
-@each $heading in $headings {
-	#{$heading} {
+// One class still outranks these; the html prefix ties core's editor reset.
+// WP 5.5-5.8 core heading styles are (0,1,1); those body classes outrank them.
+@at-root html :where(.editor-styles-wrapper),
+.branch-5-5 .editor-styles-wrapper,
+.branch-5-6 .editor-styles-wrapper,
+.branch-5-7 .editor-styles-wrapper,
+.branch-5-8 .editor-styles-wrapper {
+
+	h1,
+	h2,
+	h3,
+	h4,
+	h5,
+	h6 {
+		font-family: var(--headingsfontfamily, var(--bodyfontfamily));
+		color: var(--headingcolor, inherit);
+	}
 
-		&.wp-block,
-		& {
+	@each $heading in $headings {
+		#{$heading} {
 			font-size: var(--#{$heading}fontsize);
 			font-weight: var(--#{$heading}fontweight);
 			line-height: var(--#{$heading}lineheight);
@@ -209,9 +220,15 @@ pre:not(.CodeMirror-line) {
 
 
 // === Links === //
-a:not(.wp-block-button__link) {
+@at-root html :where(.editor-styles-wrapper) a:where(:not(.wp-block-button__link)) {
 	color: var(--nv-primary-accent);
 
+	// wp-admin's common.css loads in the editor and colours these at (0,1,1).
+	&:focus,
+	&:active {
+		color: var(--nv-primary-accent);
+	}
+
 	&:hover {
 		color: var(--nv-secondary-accent);
 		text-decoration: none;

e2e-tests/fixtures/customizer/typography/letter-spacing-reset.json

@@ -0,0 +1,26 @@
+{
+	"neve_typeface_general": {
+		"fontSize": {
+			"suffix": {
+				"mobile": "px",
+				"tablet": "px",
+				"desktop": "px"
+			},
+			"mobile": 15,
+			"tablet": 16,
+			"desktop": 16
+		},
+		"lineHeight": {
+			"mobile": 1.6,
+			"tablet": 1.6,
+			"desktop": 1.7
+		},
+		"letterSpacing": {
+			"mobile": 0,
+			"tablet": "0",
+			"desktop": 0
+		},
+		"fontWeight": "400",
+		"textTransform": "none"
+	}
+}

e2e-tests/specs/admin/dashboard-tab-hash.spec.ts

@@ -0,0 +1,19 @@
+import { test, expect } from '@playwright/test';
+
+test.describe('Dashboard tab from the URL hash', () => {
+	test('a hash naming a link-only tab opens the Welcome tab', async ({
+		page,
+	}) => {
+		const errors: string[] = [];
+		page.on('pageerror', (error) => errors.push(error.message));
+
+		// "Get Neve Pro" is a link, not a tab with content. "Starter Sites" is
+		// the same once the Starter Sites plugin is active.
+		await page.goto('wp-admin/admin.php?page=neve-welcome#get-neve-pro');
+
+		await expect(
+			page.getByRole('link', { name: 'Go to Customizer' })
+		).toBeVisible();
+		expect(errors).toEqual([]);
+	});
+});